Closed yuwenmemon closed 2 months ago
Triggered auto assignment to @puneetlath (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:
Job added to Upwork: https://www.upwork.com/jobs/~017260ab59e4fe16a6
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External
)
Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature
)
Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.
š£ @hungvu193 š An offer has been automatically sent to your Upwork account for the Contributor role š Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review š§āš» Keep in mind: Code of Conduct | Contributing š
Hey! Iām Jakub Szymczak from Software Mansion, an expert agency, and Iād like to work on this issue! I might find somebody from SWM to help me with that, so in that case we can reassign. But in the meantime feel free to assign me š
Update: Haven't started working on it. I'll probably find somebody from Software Mansion to work on this.
Cool. Still waiting for the PR...
Hi, I'm Marcin from Software Mansion, an expert agency, and I'd like to work on this issue :)
Small update here :) This is the draft PR I'll continue working on Monday.
Currently, there are Preferred exporter
and Date
pages
We probably need to wait for this one right? https://github.com/Expensify/App/issues/43532
Yes, I copied some stuff to make it work so we should wait š
Draft PR is up
I think PR is ready but I'm waiting for backend to test it throughly. @hungvu193 are there any updates on the backend PR for the export
page? š
I think @yuwenmemon or @NikkiWines can give you the BE update š
I think PR is ready but I'm waiting for backend to test it throughly. @hungvu193 are there any updates on the backend PR for the
export
page? š
Did you get the answer via slack?
@hungvu193 Yes! All questions were answered :)
tl;dr
Backend for export
is almost ready (or ready). I'll check that soon
Awesome :)
Just merged the Export APIs they should be on staging on Monday
PR will be ready for review today.
@hungvu193 I think we should split my export PR because it grows quickly (it's over 1000 lines already). I suggest adding offline and error states in a followup PR (I'll start working on it soon).
Please share your thoughts here š
@hungvu193 I think we should split my export PR because it grows quickly (it's over 1000 lines already).
I suggest adding offline and error states in a followup PR (I'll start working on it soon).
Please share your thoughts here š
Yes please go ahead š. Totally agree with you
Update:
I'd suggest we should merge https://github.com/Expensify/App/pull/43776 first then test the API and other stuff in a follow PR (https://github.com/Expensify/App/pull/44739)
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
No payment needed for me here. Feel free to close this one.
Got it, thanks!
Tracking GH: https://github.com/Expensify/Expensify/issues/388780
Design doc section: https://docs.google.com/document/d/1k3ZFw8KB55yPUSCG6KYZlwpwEtmRt3eUshwxs7bZq5I/edit#heading=h.vn04szhrriv7
You will find in the following issue the pseudocode for the different flows. Use them as a guide in your implementation.
Export flow
Main page
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @puneetlath