Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.44k stars 2.8k forks source link

[$250] Web - Track Expense - Receipt disappears when categorize IOU from Self DM #43553

Closed izarutskaya closed 1 month ago

izarutskaya commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4621286&group_by=cases:section_id&group_order=asc&group_id=309130 Email or phone of affected tester (no customers): gocemate+a223@gmail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create workspace
  3. Go to FAB> Track Expense> Finish the flow
  4. Go to Self DM and click on Categorize it
  5. Click on a existing workspace> Select any category
  6. On + button add a receipt> Complete the flow
  7. Go the IOU from Step 6 to open the detail page

Expected Result:

Added receipt should remains on created request

Actual Result:

Receipt is visible when create request and after a while it disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/0a9c8d07-572e-457b-94a0-dd5c609f53e1

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011d7985fdec28883a
  • Upwork Job ID: 1810391532944755799
  • Last Price Increase: 2024-07-15
Issue OwnerCurrent Issue Owner: @suneox
melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

izarutskaya commented 3 months ago

We think this issue might be related to the #vip-vsb

Christinadobrzyn commented 3 months ago

Just a heads up - I'm going to be ooo until June 24th so going to reassign this to a teammate

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 months ago

@anmurali Eep! 4 days overdue now. Issues have feelings too...

anmurali commented 3 months ago

I cannot reproduce this in Staging...

lanitochka17 commented 3 months ago

Issue is still reproducible

https://github.com/Expensify/App/assets/78819774/85c4cd92-91a0-4fca-bf5d-67d599830a57

melvin-bot[bot] commented 3 months ago

@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 3 months ago

@anmurali Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 3 months ago

@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 3 months ago

@anmurali Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

anmurali commented 2 months ago

I can in fact reproduce it now on staging. I am not sure if this is a front end issue but let's see what we find if we make it external. We can pull it back internal if need be.

melvin-bot[bot] commented 2 months ago

Job added to Upwork: https://www.upwork.com/jobs/~011d7985fdec28883a

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

anmurali commented 2 months ago

@thienlnam - would also appreciate you reviewing this issue to make sure a contributor can fix it.

melvin-bot[bot] commented 2 months ago

@suneox @anmurali this issue is now 4 weeks old, please consider:

Thanks!

thienlnam commented 2 months ago

This looks like it is probably an internal issue

suneox commented 2 months ago

I'll double check within few hours

suneox commented 2 months ago

I’ve tested on the latest main branch, and the backend still returns the receipt and file name after categorizing the expense. However, there is another issue with loading the thumbnail.

Screenshot 2024-07-11 at 23 29 39

and can reproduce on latest staging with same actual result

Screenshot 2024-07-11 at 23 44 08

So, I think we need internal team double-check the flow of the API requests: TrackExpense after that CategorizeTrackedExpense and then OpenReport. The transaction doesn't return “receipt” while the transaction is still scanning.

melvin-bot[bot] commented 2 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 2 months ago

@suneox, @anmurali Huh... This is 4 days overdue. Who can take care of this?

anmurali commented 2 months ago

@thienlnam @suneox - is this BE or FE fix?

thienlnam commented 2 months ago

This would be internal, but since this wave is paused it will unlikely be prioritized

melvin-bot[bot] commented 2 months ago

@suneox, @anmurali Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 2 months ago

@suneox, @anmurali Still overdue 6 days?! Let's take care of this!

suneox commented 2 months ago

Not overdue, still waiting internal fix

melvin-bot[bot] commented 2 months ago

@suneox, @anmurali Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 2 months ago

@suneox, @anmurali Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 2 months ago

@suneox, @anmurali 10 days overdue. I'm getting more depressed than Marvin.

anmurali commented 2 months ago

I can reproduce it now and I actually think this should be in wave collect. This happens when a tracked expense is categorized and as a result is put on a policy. This could be a bottom up use case and we can't have the receipts disappearing!! @trjExpensify do you agree?

trjExpensify commented 1 month ago

I don't think Track > categorise it is officially part of the bottom-up "CVP" flow. I agree we should fix it though, as it's not out of the realm of possibility someone goes down the track flow, realises they want categories, and hits this bug when upgrading to a collect workspace to access them.

Going to move it into Hot Picks.

melvin-bot[bot] commented 1 month ago

@suneox, @anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

trjExpensify commented 1 month ago

@thienlnam while you wait on Dan's PR for https://github.com/Expensify/App/issues/44615, can you look into this?

melvin-bot[bot] commented 1 month ago

@suneox, @anmurali Still overdue 6 days?! Let's take care of this!

anmurali commented 1 month ago

Not overdue. Waiting for @thienlnam to take a look.

suneox commented 1 month ago

This issue will be handled by the internal team, so I’d like to self-unassign

thienlnam commented 1 month ago

Auth PR merged, Web-E PR pending review once auth deployed

melvin-bot[bot] commented 1 month ago

@anmurali, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 1 month ago

@anmurali, @thienlnam Huh... This is 4 days overdue. Who can take care of this?

thienlnam commented 1 month ago

All done