Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.12k stars 2.61k forks source link

LHN - LHN does not display HTML code text on the message preview #43563

Open m-natarajan opened 3 weeks ago

m-natarajan commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4620777 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Pre-requisite: the user must be logged in.

  1. Go to any chat.
  2. Send this message: <a href=""takia.html"">asd
  3. Verify that LHN message preview only displays "asd" and not the entire message.

Expected Result:

The entire message should be displayed on the message preview on LHN.

Actual Result:

The HTML code text is not displayed on the message preview on LHN, only the text that the code contains.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6510214_1718164484854!image

View all open jobs on GitHub

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

m-natarajan commented 3 weeks ago

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

m-natarajan commented 3 weeks ago

We think that this bug might be related to #vip-vsb

bernhardoj commented 3 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN last message doesn't show HTML code written in plain text.

What is the root cause of that problem?

This happens after https://github.com/Expensify/App/pull/40845 is merged. In that PR, we are converting HTML to text, so the HTML code is removed but you can still see the text inside the HTML tag. https://github.com/Expensify/App/blob/b70b136c0c30c4948798888ff1722dceba96d0e6/src/components/LHNOptionsList/OptionRowLHN.tsx#L243

It's to solve this issue where the last message text of the workspace #admins chat contains an HTML tag. It was a BE issue because the last message text shouldn't include any HTML tag. The one that includes the HTML tag is the last message HTML.

What changes do you think we should make in order to solve the problem?

Revert the change from https://github.com/Expensify/App/pull/40845.

I can't repro the BE issue anymore, if anyone can repro it, then it should be fixed on the BE first.

melvin-bot[bot] commented 2 weeks ago

@abekkala Eep! 4 days overdue now. Issues have feelings too...

abekkala commented 2 weeks ago

https://expensify.slack.com/archives/C01SKUP7QR0/p1718735202154699

abekkala commented 2 weeks ago

this will be handled by SWM

melvin-bot[bot] commented 1 week ago

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

abekkala commented 1 week ago

Not overdue - SWM will be picking this up

BartoszGrajdek commented 1 week ago

Hi, I'm Bartosz from SWM react-native-live-markdown team! I'll take a look at the problem here later this week! 👀

melvin-bot[bot] commented 1 week ago

@abekkala this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

abekkala commented 1 week ago

Thanks @BartoszGrajdek

abekkala commented 5 days ago

being worked on by SWM - @BartoszGrajdek

BartoszGrajdek commented 4 days ago

Hi! I'm going OOO 4.07-7.07. At the beginning of next week, we'll check if there's anyone available to handle it @ SWM, we may have some more people available to work on this.

I was busy handling issues with a higher priority in recent days, so sorry for the delay here 🙏🏻