Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD][$250] Send invoice - Unable to dismiss error after editing the amount of paid invoice #43577

Closed lanitochka17 closed 2 months ago

lanitochka17 commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. [User A] Send invoice to User B
  3. [User A and B] Go to invoice thread
  4. [User B] Pay the invoice
  5. [User A] Quickly change the amount
  6. [User A] Dismiss the error under the amount edit system message

Expected Result:

User A will be able to dismiss the error under the amount edit system message

Actual Result:

User A is unable to dismiss the error under the amount edit system message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/2fee6c73-3c74-48b4-9a5f-00a8d0b11f48

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016ab97d06171fcfe0
  • Upwork Job ID: 1801113320162208595
  • Last Price Increase: 2024-06-27
  • Automatic offers:
    • ZhenjaHorbach | Contributor | 102939661
Issue OwnerCurrent Issue Owner: @cristipaval
MariaHCD commented 4 months ago

Hmm, I don't have the most context on the SendInvoice API command. @cristipaval would you mind taking a look here?

I can take a closer look tomorrow.

cristipaval commented 4 months ago

yes, I do agree that this is a BE issue as per this proposal. I can take it over, @MariaHCD if you're busy with other staff.

MariaHCD commented 4 months ago

Cool, sounds good! Thanks, @cristipaval!

dominictb commented 4 months ago

@cristipaval As per my proposal, we still need FE change to add another param to SendInvoice API. Since the C+ also approved my proposal here, can you please assign me here, and then I can handle the FE change once the BE change is complete?

cristipaval commented 4 months ago

Held on https://github.com/Expensify/App/issues/43797

cristipaval commented 4 months ago

@cristipaval As per my proposal, we still need FE change to add another param to SendInvoice API. Since the C+ also approved my proposal here, can you please assign me here, and then I can handle the FE change once the BE change is complete?

This issue has the same root cause as this one, and we already have a contributor who proposed a more complete solution.

ZhenjaHorbach commented 3 months ago

Not overdue Another issue is in progress

cristipaval commented 3 months ago

Still held

cristipaval commented 3 months ago

still held

cristipaval commented 3 months ago

We're actively working on the issue that this one is held on

rayane-djouah commented 2 months ago

PR is merged

cristipaval commented 2 months ago

The PR fixing the issue that this one is held on has been merged. Waiting for it to get deployed.

cristipaval commented 2 months ago

This issue can be retested in staging

ZhenjaHorbach commented 2 months ago

@cristipaval @kadiealexander I can't reproduce Let's close this issue !

ZhenjaHorbach commented 2 months ago

@cristipaval @kadiealexander Friendly bump !

Maybe we should ping the testers for final confirmation to close this issue?