Closed m-natarajan closed 1 week ago
I have pushed the latest changes except the navigation fix you have suggested me
Which screens do open contact method details page?
ContactMethodDetailsPage
) form BankAccountStep
page, which is rendered by ReimbursementAccountPage
page. ReimbursementAccountPage
page is defined here and here in Modal stack navigator CodesStep
from TwoFactorAuthPage
page opens ContactMethodDetailsPage
For context, the feature - 'verify your account here' link - that navigates user form BankAccountStep
to ContactMethodDetails
page is introduced in this PR
Okay so just to make clear. Before it could be open from only one page:
And now we want to be able to open it from two different pages:
Also bonus question. Do you know from which screens we can open the connect bank account? I can see that it has backTo param already
That is right! BankAccountStep
can be opened from WorkspaceWorkflowsPage
. I am not sure if other pages use the same component. Wallet section seems to be using different pages EnablePaymentsPage
I created diff with new changes. Please check if it works for you. The screen under the overlay won't change if the user opens CONTACT_METHOD_DETAILS
page.
backToDiff.txt
I created diff with new changes. Please check if it works for you. The screen under the overlay won't change if the user opens
CONTACT_METHOD_DETAILS
page. backToDiff.txt
I have tried the diff. And it seems to be working well 🎉. Thanks @adamgrzybowski 🙇🏻♂️. I will test this thoroughly, if things will go as expected PR will ready for final review soon.
https://github.com/user-attachments/assets/0ee8e37b-8401-4704-a643-e10cadcabe3d
@mollfpr PR is ready for final review 🎉
This issue has not been updated in over 15 days. @trjExpensify, @mollfpr, @techievivek, @etCoderDysto eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.23-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-29. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
@trjExpensify Not sure why it says I require payment here as my only involvement with this issue is that I reported it (see OP reported by) 🤷♂️
Same, all good though. Thanks for flagging!
@mollfpr, checklist time!
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR: [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
No offending PR.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression step should be enough.
[@mollfpr] Determine if we should create a regression test for this bug. [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Precondition: Login with a new email and don't verify the account.
Precondition: Login with a new email and don't verify the account.
It would be better to say, "Login with a new public email account"(this is so because we require verification for the user if they are part of domain control). Otherwise, it looks good to me.
Thanks! Payment summary as follows:
Luthfi, go ahead and request. @etCoderDysto, I need your Upwork profile link please.
@trjExpensify here is a link to my Upwork profile: https://www.upwork.com/freelancers/~01ea78e0164390eb79 Thanks!
Offer sent!
I have accepted the offer. Thanks!
Paid, closing!
$250 approved for @mollfpr
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.82-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @ikevin127 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718145760414179
Action Performed:
Precondition: Login with a new email and don't verify account. Note: This means that you login with a new email and you're not asked to input the magic code, unless you do this manually by navigating to Settings > Profile > Contact method > click on your email to verify it.
Expected Result:
Actual Result:
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/e020732b-9eab-4736-b138-25d1dcf2178f
https://github.com/Expensify/App/assets/38435837/e8071b83-3d23-482c-966e-74cbd6352c2b
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @trjExpensify