Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

LHN-Reports/chats missing in LHN when logging in to account in "#focus" priority mode #43612

Closed lanitochka17 closed 1 month ago

lanitochka17 commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in to New Expensify with account applausetester+ak6122nd@applause.expensifail.com
  2. Note the amount of reports in LHN
  3. Navigate to settings > Preferences
  4. Change priority mode to "#focus"
  5. Log out and log in with the same account
  6. Change the priority mode back to Most Recent

Expected Result:

The same amount of chats should be displayed as in Step 2

Actual Result:

Many chats (depending on the amount in account) are missing in LHN The chats do not reappear after refreshing the page/relaunching the app, user is forced to change priority mode to most recent and relog to see all reports in LHN Not reproducible for pinned/GBR chats.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5534c0c6-13a8-4d13-a081-9c17780c3ec3

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013c1484a9570e0a56
  • Upwork Job ID: 1801290617630180667
  • Last Price Increase: 2024-07-15
melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 5 months ago

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

melvin-bot[bot] commented 5 months ago

Job added to Upwork: https://www.upwork.com/jobs/~013c1484a9570e0a56

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

melvin-bot[bot] commented 4 months ago

@twisterdotcom, @getusha Eep! 4 days overdue now. Issues have feelings too...

twisterdotcom commented 4 months ago

Waiting on proposals

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

getusha commented 4 months ago

Waiting for proposals

twisterdotcom commented 4 months ago

Doubling

melvin-bot[bot] commented 4 months ago

Upwork job price has been updated to $500

melvin-bot[bot] commented 4 months ago

@twisterdotcom @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

twisterdotcom commented 4 months ago

Still waiting on proposals.

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

twisterdotcom commented 4 months ago

Okay, I'm not clear if this is still an issue. I tested it with pecan@expensivepie.com and couldn't recreate. Gonna ask for a retest.

mvtglobally commented 4 months ago

Issue is reproducible during KI retests.

https://github.com/Expensify/App/assets/43995119/06a72e13-eaf7-4f3f-9675-14846e4fbc97

twisterdotcom commented 4 months ago

Okay, so the recreation steps should be amended a bit:

  1. Log in to any account
  2. Make the preference "Most recent"
  3. Pin a few of the chats, but leave some unpinned and without drafts
  4. Switch to Focus mode
  5. Sign in to the same account in a different browser window
  6. Switch back to "Most recent"
  7. See we did not load the unpinned chats into the LHN.
melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 4 months ago

@twisterdotcom @getusha this issue is now 4 weeks old, please consider:

Thanks!

Kureev commented 4 months ago

Hi, I am Alexey from Margelo and I can work on this issue.

melvin-bot[bot] commented 4 months ago

📣 @Kureev! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Kureev commented 3 months ago

This one is likely to be a BE issue: when we switch the priority mode in preferences, the request is sent to BE to update chat priority mode. The request seems correct and work properly when we switch modes from default to focus and back, however, if we switch the mode to focus, log out, log in again and switch it back to default (see ticket description), it seems that the next OpenReport query returns old data (3 records instead of 5 in my case), even though the flag has been changed

twisterdotcom commented 3 months ago

@getusha do you agree?

getusha commented 3 months ago

Yes, it looks like a backend issue. I see that nvp_priorityMode is set to the correct value, but as @Kureev mentioned, OpenReport is returning the filtered data despite the change.

twisterdotcom commented 3 months ago

Okay, let's make this internal.

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @aldo-expensify (AutoAssignerNewDotQuality)

muttmuure commented 3 months ago

I've just realized. This isn't a quality issue

muttmuure commented 3 months ago

It's a regular bug, because it's reliably reproduced.

muttmuure commented 3 months ago

I'm going to remove it from the project (sorry!)

twisterdotcom commented 2 months ago

Okay, this is still Internal and super annoying because it means your LHN is out of sync. Seems we know the problem, we just need somebody internal to take it on.

twisterdotcom commented 2 months ago

No internal assignee yet. Going to downgrade to Monthly given no uptake. We'll eventually get to Not a priority and then closed.

twisterdotcom commented 1 month ago

Not a priority it seems then