search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

[HOLD for payment 2024-07-24] [$250] Categorizing - Workspace member has option to edit categories, which leads to not here page #43623

Closed kavimuru closed 1 month ago

kavimuru commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.82-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Track expense.
  3. Track a manual expense.
  4. Click Categorize it from the actionable whisper.
  5. Select the workspace that has disabled all the categories.
  6. Click Edit categories.

Expected Result:

In Step 6, there should be no option for workspace member to "edit categories". Also, because the member is not an admin, the empty categories page should say this for the title "{workspaceName} doesn't have any categories enabled", and this for the subtext "Categorize this expense by choosing a different workspace, or [ask your admin](link to member's policy expense chat) to enabled categories for this workspace". Lets swap out the Categories button with a "Got it" button which navigates back to the workspace selector.

Here is an example mockup, but we can probably use the existing illustration and only update the text on the page when the member is not an admin.

Here is the Slack thread where this was discussed.

Actual Result:

In Step 6, there is an option for workspace member to "edit categories", which leads to not here page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/43996225/abeb0194-ab33-48a9-b4b5-e4666ba4ad64

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01693c1a6724bab4ab
  • Upwork Job ID: 1801197084944850945
  • Last Price Increase: 2024-06-13
  • Automatic offers:
    • allgandalf | Reviewer | 102782628
Issue OwnerCurrent Issue Owner: @adelekennedy
daledah commented 1 month ago

@adelekennedy I did it, thanks for the kind bump

adelekennedy commented 1 month ago

payment made! Closing this