Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.14k stars 2.64k forks source link

[$250] Scan - No error pop-up and scan expense with corrupted PDF can be submitted via QAB #43645

Open izarutskaya opened 1 month ago

izarutskaya commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.82-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4622999 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Go to + > Submit expense > Scan.
  4. Upload a corrupted PDF (attached below).
  5. Note that it shows error pop-up and the expense is not submitted.
  6. Submit a manual request in the workspace chat.
  7. Go to FAB > Submit expense under QAB > Scan.
  8. Upload the same corrupted PDF.

Expected Result:

App will show error pop-up and the scan expense is not submitted.

Actual Result:

There is inconsistency in submitting corrupted PDF via FAB and QAB. App shows error pop-up and the expense is not submitted when submitting via FAB. App does not show error pop-up and the scan expense is submitted when submitting via QAB.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/ba369c96-6013-4809-8851-a61680c25490

LARGE PDF FILE corrupted.pdf

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013830a17b8e9e0b20
  • Upwork Job ID: 1801414678071173121
  • Last Price Increase: 2024-06-14
  • Automatic offers:
    • suneox | Reviewer | 102912100
    • Krishna2323 | Contributor | 102912103
Issue OwnerCurrent Issue Owner: @suneox