Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.29k stars 2.72k forks source link

[HOLD for payment 2024-08-02] [HOLD for payment 2024-07-25] [$500] Web - Expense - Blue border selection on back icon RHP after hitting enter on BNP #43662

Closed lanitochka17 closed 1 month ago

lanitochka17 commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat
  3. Go to + > Submit expense > Manual
  4. Enter amount
  5. Hit Enter

Expected Result:

The back icon on RHP will not have blue border selection

Actual Result:

The back icon on RHP has blue border selection

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/cd5b4495-0c04-40dd-bac9-1c8018391d49

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018358d1ec7f51e120
  • Upwork Job ID: 1801251133562170195
  • Last Price Increase: 2024-06-27
  • Automatic offers:
    • suneox | Contributor | 102988636
Issue OwnerCurrent Issue Owner: @s77rt
melvin-bot[bot] commented 1 month ago

Issue is ready for payment but no BZ is assigned. @joekaufmanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

joekaufmanexpensify commented 1 month ago

All set to issue payment. We need to pay:

joekaufmanexpensify commented 1 month ago

@suneox $500 sent and contract ended!

joekaufmanexpensify commented 1 month ago

Upwork job closed.

joekaufmanexpensify commented 1 month ago

All that's left is for @s77rt to request their $500 via NewDot. Going to close this one since it's otherwise all set. Thanks everyone!

s77rt commented 1 month ago

@joekaufmanexpensify This should be $250 for causing a regression https://github.com/Expensify/App/issues/45571

JmillsExpensify commented 1 month ago

@joekaufmanexpensify mind updating the payment summary above?

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.12-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-02. :confetti_ball:

For reference, here are some details about the assignees on this issue:

joekaufmanexpensify commented 1 month ago

Ah okay got it. I don't see that there was a post to the issue about the deploy blocker/regression previously, which is why it was not previously noted in the payment summary.

Updated payment summary to note that both parties are actually due $250 here because of the regression.

joekaufmanexpensify commented 1 month ago

I need to request a $250 refund from @suneox via Upwork. Getting an insufficient permissions error in upwork requesting a refund. Updating my permissions via this SO to allow processing refunds.

suneox commented 1 month ago

I need to request a $250 refund from @suneox via Upwork. Getting an insufficient permissions error in upwork requesting a refund. Updating my permissions via this SO to allow processing refunds.

Sure, I'm looking for the refund section on Upwork and process ASAP

joekaufmanexpensify commented 1 month ago

All good!I haven't requested it yet. Will let you know once I do!

suneox commented 1 month ago

@joekaufmanexpensify I have refunded 50%

joekaufmanexpensify commented 1 month ago

Ah, perfect. TY! I see it processed on my end.

joekaufmanexpensify commented 1 month ago

Okay, now all that's left is to process $250 payment to @s77rt. Payment summary here.

JmillsExpensify commented 1 month ago

$250 approved for @s77rt