[HOLD for payment 2024-07-24] [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.29k stars 2.72k forks source link

[HOLD for payment 2024-07-24] [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends #43671

Closed MitchExpensify closed 1 month ago

MitchExpensify commented 2 months ago

This covers this section of the design doc:

cc @fabioh8010 @pac-guerreiro as you'll be picking this up

Issue Owner

Current Issue Owner: @sakluger

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

sakluger commented 2 months ago

Sounds like this will be handled internally - I asked @MitchExpensify to confirm.

trjExpensify commented 2 months ago

Hm, this is a frontend issue isn't it?

fabioh8010 commented 2 months ago

@trjExpensify Yes, it's frontend issue

sakluger commented 2 months ago

Ah sorry, @fabioh8010 and @pac-guerreiro are both from Callstack and will be working on all Free Trial related projects.

@fabioh8010 and @pac-guerreiro, will both of you be working on this GH issue or just one of you? And will there be one or multiple PRs?

Thanks!

fabioh8010 commented 2 months ago

@sakluger Just one of us (not decided who is going to pick at the moment), and will probably be one PR.

trjExpensify commented 2 months ago

Put this on hold for https://github.com/Expensify/App/issues/43672 where we'll first tackle the logic for when a free trial starts, before here and when a free trial ends.

sakluger commented 2 months ago

Thanks for clarifying, @fabioh8010. Let me know once you are ready for one of you to take it so that I can reassign the issue if needed.

sakluger commented 2 months ago

I'm going to move this to weekly while we wait for the hold issue to be completed.

pac-guerreiro commented 2 months ago

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

rojiphil commented 2 months ago

@trjExpensify @sakluger And I can pick this up for review as C+

trjExpensify commented 2 months ago

Awesome!

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/44483

If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@rojiphil requires payment (Needs manual offer from BZ)
@pac-guerreiro does not require payment (Contractor)

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@rojiphil] Determine if we should create a regression test for this bug.
[ ] [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

sakluger commented 1 month ago

Summarizing payment on this issue:

Contributor: @pac-guerreiro - no payment required (Contractor) Contributor+: @rojiphil $250, sent offer via Upwork: https://www.upwork.com/nx/wm/offer/103240375

rojiphil commented 1 month ago

sent offer via Upwork: https://www.upwork.com/nx/wm/offer/103240375

@sakluger Accepted the offer. Thanks.

sakluger commented 1 month ago

Great, thanks! Payment is complete.