[$250] mWeb - Chat - Emoji picker cut off in the bottom

lanitochka17 commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.83-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

Log in to New Expensify
Navigate to any chat
Open emoji picker

Expected Result:

Emoji picker should be fully rendered to the very bottom of the screen

Actual Result:

Emoji picker is cut off in the bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/fe59e6a5-b101-4b4b-8f9d-3508b8deec4d

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015d3ee2fb419bfdb5
Upwork Job ID: 1801295914996738899
Last Price Increase: 2024-06-13

Issue Owner

Current Issue Owner: @rayane-djouah

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 2 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

lanitochka17 commented 2 months ago

@deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 2 months ago

We think that this bug might be related to #vip-vsp

melvin-bot[bot] commented 2 months ago

Job added to Upwork: https://www.upwork.com/jobs/~015d3ee2fb419bfdb5

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

mountiny commented 2 months ago

This does not feel like a blocker to me, feel free to change that but demoting

daledah commented 2 months ago

Please re-state the problem that we are trying to solve in this issue.

Emoji picker is cut off in the bottom

What is the root cause of that problem?

In here , We added an extra View without any style when we added FocusTrap before.

What changes do you think we should make in order to solve the problem?

We can fix this bug by Remove the extra View

https://github.com/Expensify/App/blob/361a0000f119618b49076fa51e53560ec2195ac1/src/components/Modal/BaseModal.tsx#L256

What alternative solutions did you explore? (Optional)

melvin-bot[bot] commented 2 months ago

📣 @daledah! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:
```
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
```