[HOLD for Payment 8/28] [$250] Billable - Billable toggle becomes disabled when tracking expense with billable toggle enabled

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4631171 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• "Re-bill expenses to clients" is set to "Default to Billable" on Old Dot.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go to + > Track expense > Manual.
4. Track a manual expense with billable toggle enabled.
5. Go to transaction thread.

Expected Result:

Billable toggle will remain enabled.

Actual Result:

Billable toggle becomes disabled. This issue only happens with tracked expenses and not submitted expenses.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/3a5c5e30-9d58-415b-918f-833bc1835c64

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d112a7853dd092a2
• Upwork Job ID: 1808520953526046967
• Last Price Increase: 2024-07-24

[melvin-bot[bot]]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[jacobkim9881]

I think this issue might be related to BE.

[melvin-bot[bot]]

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

I am not able to recreate as I am getting the infinite skeleton loader (context here). Going to see if this can be retested by QA

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[CortneyOfstad]

Not overdue as we're waiting for it to be retested by QA

[CortneyOfstad]

Still waiting for it to be retested, as I cannot recreate

[CortneyOfstad]

Still waiting for this to be tested, as I still cannot recreate!

[melvin-bot[bot]]

@CortneyOfstad this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

Still waiting for this to be tested since my test account is still impacted by the infinite skeleton loader (GH here)

[mvtglobally]

Issue is reproducible during KI retests.

https://github.com/Expensify/App/assets/43995119/2e4318ad-f783-475f-b8d0-b0d0551c5f36

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01d112a7853dd092a2

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[CortneyOfstad]

Post in wave collect here

[CortneyOfstad]

@ishpaul777 based on the comment here can you confirm if this is a BE issue?

[CortneyOfstad]

So confirmed with Tom that this is VIP-VSB. That is paused for now, so adjusting to weekly

[ishpaul777]

This looks like a backend issue becuase optimistically we do enable the billable option by default, it got disabled after request is completed.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@CortneyOfstad @ishpaul777 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[ishpaul777]

not overdue, awaiting Proposals ( most likely though it appears to be backend bug but lets see..)

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ishpaul777]

🎀 👀 🎀 (for internal engineer assignment)

[melvin-bot[bot]]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[ishpaul777]

Hello @tylerkaraszewski this appears to be a backend internal issue Could you please take a look or assign someone who can. Thanks!

[melvin-bot[bot]]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[CortneyOfstad]

Thanks @ishpaul777 — I've adjusted the tags to reflect and internal issue. @tylerkaraszewski do you have the bandwidth to take this on?

Also @johncschuster I am heading OoO so reassigned this in the meantime to keep eyes on it — thanks!

[tylerkaraszewski]

@CortneyOfstad I don't really have time to work on this right away. If someone else would like to take it, they're welcome.

[melvin-bot[bot]]

@tylerkaraszewski, @johncschuster, @CortneyOfstad, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?

[johncschuster]

VIP-VSB has been deprioritized. I wonder if this can be moved to #wave-collect. If not, we will likely need to close this for now.

[johncschuster]

@trjExpensify, do you feel like this could fit under #wave-collect?

[trjExpensify]

Ah, okay.. it's using track on a workspace. Okay cool, we can move it in.

I could be wrong, but I think it's because TrackExpense here in the TransactionAPI in Web-E doesn't include billable. So we aren't doing anything with that toggle on the frontend.

CC: @thienlnam

[thienlnam]

That was by design though, tracked expenses are by nature not billable or reimbursable. Is there a use-case for that?

[trjExpensify]

If it was by design, why can you select the Billable toggle when you use Track expense on a workspace?

But either way, yes, I think there's a case for "I'm tracking the expenses I incur for my business on a workspace, and billing some of those expenses on to my clients".

[ishpaul777]

not overdue, actively discussing what should be the expected behaviour.

[thienlnam]

If it was by design, why can you select the Billable toggle when you use Track expense on a workspace?

This was probably added later - but we can have the billable flag get passed to the API. Will require some auth changes as well

[CortneyOfstad]

I'm back from OoO @johncschuster — thanks for holding down the fort while I was gone!

[melvin-bot[bot]]

@tylerkaraszewski, @johncschuster, @CortneyOfstad, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

Just catching up on this one. It sounds like we've come to the conclusion that we could pass the billable flag via the API. Do we all agree that that's the direction we're going to go? If so, who's doing that?

[thienlnam]

These PRs are currently in review by @pecanoro - looks like she is OOO but should be back next week

• https://github.com/Expensify/Auth/pull/11971
• https://github.com/Expensify/Web-Expensify/pull/43068

[CortneyOfstad]

Thanks @thienlnam for the update!

[CortneyOfstad]

So the PRs went into production today, so with the 7-day holding period, the date will be 8/28, so changing the title to reflect that 👍

[ishpaul777]

I dont there was a App PR so there is no payment due

[mvtglobally]

Issue not reproducible during KI retests. (First week)