[PAID] [VIP][Travel] handle errors when spotnana token isn't created

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.29k stars 2.72k forks source link

[PAID] [VIP][Travel] handle errors when spotnana token isn't created #43780

Closed rushatgabhane closed 1 week ago

rushatgabhane commented 2 months ago

Coming from https://github.com/Expensify/App/pull/43081#discussion_r1633984988

We should handle errors by showing a RBR when spotnana token can't be generated. Do a pre-design for how errors should be handled, and then implement it.

2 - Make sure to do the same for AcceptSpotnanaTerms command

src/libs/actions/Travel.ts

Issue Owner

Current Issue Owner: @rushatgabhane

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

rushatgabhane commented 2 months ago

@strepanier03 please assign this issue to me

melvin-bot[bot] commented 2 months ago

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

strepanier03 commented 2 months ago

Assigned!

rushatgabhane commented 2 months ago

no updates yet

rushatgabhane commented 2 months ago

PR hit staging

melvin-bot[bot] commented 2 months ago

@strepanier03 @rushatgabhane this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 2 months ago

@strepanier03, @rushatgabhane Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 2 months ago

@strepanier03, @rushatgabhane 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 2 months ago

@strepanier03, @rushatgabhane 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] commented 1 month ago

@strepanier03, @rushatgabhane 12 days overdue now... This issue's end is nigh!

melvin-bot[bot] commented 1 month ago

This issue has not been updated in over 14 days. @strepanier03, @rushatgabhane eroding to Weekly issue.

rushatgabhane commented 1 month ago

PR above ^

rushatgabhane commented 4 weeks ago

PR on staging and tests well

melvin-bot[bot] commented 4 weeks ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 4 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.17-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/46333

If no regressions arise, payment will be issued on 2024-08-14. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@rushatgabhane requires payment through NewDot Manual Requests

melvin-bot[bot] commented 4 weeks ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@rushatgabhane] Determine if we should create a regression test for this bug.
[ ] [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 3 weeks ago

Payment Summary

[Upwork Job]()

Reviewer: @rushatgabhane owed $250 via NewDot

BugZero Checklist (@strepanier03)

[x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
[x] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[x] I have verified the payment summary above is correct

strepanier03 commented 2 weeks ago

@rushatgabhane - I'll check in later for the checklist.

strepanier03 commented 2 weeks ago

Friendly bump on the checklist so we can wrap this one up.

melvin-bot[bot] commented 2 weeks ago

@strepanier03, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

rushatgabhane commented 2 weeks ago

The PR that introduced the bug has been identified. Link to the PR: N.A. this was planned to be handled later
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Yes

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

  1. Go to a new account that is on travel beta
  2. Green `+` > Book travel
  3. Click book travel
  4. Accept spotnana term
  5. Verify that if an error happens due to any reason like API being down, an error message is shown.

JmillsExpensify commented 2 weeks ago

$250 approved for @rushatgabhane

strepanier03 commented 1 week ago

REg test created and request is paid, closing now.