Closed lanitochka17 closed 1 month ago
Also, I found out another bug: The OpenReport API return 2 created action in invoice room
@cristipaval - Could you please provide us with the exact names of the parameters that you added to the endpoint?
@cristipaval - Could you please provide us with the exact names of the parameters that you added to the endpoint?
Okay, thanks! We need to add createdIOUReportActionID
and createdReportActionIDForThread
to the frontend (cc @truph01)
Also, I found out another bug: The OpenReport API return 2 created action in invoice room
@cristipaval Have you checked this bug?
FYI, it leads to the behavior:
Also, the step 11:
In Step 11, user is navigated to the same invoice thread instead of the main chat
I believe this is expected behavior. We have previously closed similar issues related to the one transaction report flow. Since the system message thread is a child of the transaction thread report, clicking on the subtitle header in step 11 should navigate to the transaction thread report.
I haven't yet, but I'm getting closer to wrapping up my other projects and then jump again into Invoicing stuff
@cristipaval Do you have any update on it?
@cristipaval, @dylanexpensify, @rayane-djouah, @truph01 Eep! 4 days overdue now. Issues have feelings too...
I'll investigate this one later today
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Also, I found out another bug: The OpenReport API return 2 created action in invoice room
@cristipaval Have you checked this bug?
@truph01, I think you get 2 CREATED
report actions when you click a preview of an invoice from the invoice room, correct? It is the expected behavior. It happens the same when you open an expense report with a single expense on it.
Because the invoice has 1 transaction on it, the user is navigated straight to the transaction thread and the OpenReport
API command returns the report actions of both the invoice report and the transaction thread report.
@truph01 - Friendly reminder 😄
@cristipaval I checked and saw that for exepnse report when it only has one transaction, BE still returns only one CREATED
action. About the report actions in combine report, we will merge the actions from the money request report and transaction thread report here
Ok, I haven't found any backend logic to return only one CREATED action when merging the actions from the expense report and transaction thread. I'll investigate again today.
@cristipaval Do you have any updates on this?
I investigated and I don't see code in the backend to filter out any CREATED action. I also tested with the App and verified that when you open an expense report with only one transaction, you get the CREATED action for both the expense report and the transaction thread report as well. cc @NikkiWines as I know you worked on merging the transaction thread with the expense report.
Hmm, yeah all the filtering done for the oneTransactionReport view is done in the front-end afaik
Thanks @NikkiWines! So @truph01, let me know if you need anything else from the backend in order to move with the implementation for this issue.
@cristipaval
You are talking about the invoice room, but you are showing screenshots of the invoice report. Now I understand the issue. There are 2 CREATED report actions for the invoice report PLUS the one that belongs to the transaction thread. I could reproduce.
Pushing a fix asap.
For your clarity:
@cristipaval Thanks for your information.
Thanks for bearing with me! I'll let you know when the backend is ready
Also, could you please give me a list of the IDs of the invoice reports that you created with 2 CREATED actions? I would run a query to remove the duplicates.
@cristipaval The invoice report ID with 2 CREATED actions is 7477380290328742
Adding @madmax330 to this issue to keep him in the loop, as I might disappear on parental leave anytime soon
TLDR:
We are waiting for the Auth PR to be deployed.
@truph01, the backend is ready. Just to let you know, this is fixed for the new invoice rooms. The old ones with 2 CREATED report actions still need to be cleaned up.
Click on report preview to open the invoice report. Observe that there are 2 CREATED report actions in here. (Bug)
Go to Troubleshoot > Clear cache and restart.
Open the invoice report again. Observer that there is 1 CREATED report actions in here.
RCA: When calling SendInvoice API, we optimistically created CREATED action A for the invoice report. But when we call API OpenReport in the invoice report, BE also return another CREATED action. So we have 2 CREATED actions.
Solution: I think when calling SendInvoice API, we should send something like createdInvoiceReportActionID
to BE.
@truph01 - Could you please push the latest changes in the draft PR to make debugging easier
@rayane-djouah I push the latest changes in the draft PR.
Also, I updated comment to include my suggestion changes.
@truph01 - I see in the draft PR that you're not sending createdIOUReportActionID
and createdReportActionIDForThread
correctly to the BE according to https://github.com/Expensify/App/issues/43797#issuecomment-2255774662 https://github.com/Expensify/App/issues/43797#issuecomment-2256610204
@rayane-djouah Ah, my bad. Beside createdIOUReportActionID
and createdReportActionIDForThread
, I need to send reportActionID
to BE as well. I pushed the code changes and now it works well. PR is ready to review.
@cristipaval Plz ignore my comment above.
PR is merged
Waiting for the PR to get deployed.
@cristipaval - Reminder that the old reports with 2 CREATED report actions still need to be cleaned up. Are you tracking this internally?
Bump @cristipaval 🙇♂️
@cristipaval - Reminder that the old reports with 2 CREATED report actions still need to be cleaned up. Are you tracking this internally?
I don't think it makes sense to spend time on cleaning that as we don't have active users using the invoice rooms yet.
@madmax330, do you think we should run some custom queries to clean the DB, or should we deal with it if it becomes a real problem?
⚠️ We just got confirmation on Slack that the Deploy Checklist: New Expensify 2024-08-26 which includes the PR of this issue was only deployed to production in Deploy Checklist: New Expensify 2024-08-28. More context on why this happened can be found in this Slack thread and this Slack comment.
Given the context above, this issue should be on [HOLD for Payment 2024-09-6] according to today's production deploy from Deploy Checklist: New Expensify 2024-08-28.
cc @dylanexpensify
do you think we should run some custom queries to clean the DB, or should we deal with it if it becomes a real problem?
@cristipaval are they real users or test users? Let's clean them up anyway so we don't spend time looking into it later?
@madmax330 - It looks like @cristipaval is on parental leave, could you please create an internal issue for this? Thanks!
@madmax330, @cristipaval, @dylanexpensify, @rayane-djouah, @truph01 Eep! 4 days overdue now. Issues have feelings too...
@madmax330 shall we get a new engineer on this? Or are you on it?
@dylanexpensify actually I think we can just close this out since it was fixed already and the 2 report actions don't cause much of a problem
@dylanexpensify This is due payment - https://github.com/Expensify/App/issues/43797#issuecomment-2322826669 Thanks!
Cool is there a payment summary already?
@madmax330, @cristipaval, @dylanexpensify, @rayane-djouah, @truph01 Huh... This is 4 days overdue. Who can take care of this?
Payment summary:
Contributor: @truph01 $250 Contributor+: @rayane-djouah $250
Please apply/request!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.84-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
In Step 7, "Reply in thread" should be available for both invoice sender and receiver In Step 10, the invoice thread should have no visual issue In Step 11, user should be navigated to the main chat
Actual Result:
In Step 7, "Reply in thread" is missing for invoice sender but present for invoice receiver In Step 10, the invoice details appear broken above existing invoice details In Step 11, user is navigated to the same invoice thread instead of the main chat
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/650bc6bb-7e6a-401d-91ae-12d5bfbb759c
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @dylanexpensify