[$250] Save the world - Principals whisper message in #teachers-unite shows the teacher as "Hidden"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.84-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4635818&group_by=cases:section_id&group_id=229065&group_order=asc Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with an expensifail account
3. Navigate to Account settings - Save the world - I know a teacher
4. Input anything for the name fields, and an expensifail email address to the email field
5. Click on the "Let's do this!" button

Expected Result:

The principal added the teacher with a full name and email address so the name or at least, the email address should be shown

Actual Result:

Principals whisper message from Expensify.org Admin in #teachers-unite shows the teacher as "Hidden"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/6322a374-d95b-4276-a80b-7e4300f54f3d

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0106b42c9c00ea9afa
• Upwork Job ID: 1803768783432548906
• Last Price Increase: 2024-07-04

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[jainilparikh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Teachers name is not visible instead hidden@ is shown.

What is the root cause of that problem?

A. Onyx now defaults to -1 instead of ' ' based on a recent PR. So, for teachers who don't have an expensify account, htmlAttribAccountID is now -1 instead of ''.

When creating the mentions message, we check for this condition:

https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx#L59

Which was previously false, because htmlAttribAccountID was '' and isEmpty returned true. But now, htmlAttribAccountID is defaulted to -1 so, isEmpty returns false causing the above condition to evaluate to true causing the Hidden message to appear.

What changes do you think we should make in order to solve the problem?

Replace this line: https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.tsx#L59

with:

if (!isEmpty(htmlAttribAccountID) && htmlAttribAccountID != '-1') {
}

What alternative solutions did you explore? (Optional)

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Save the world - Principals whisper a message in #teachers-unite shows the teacher as "Hidden"

What is the root cause of that problem?

The main root cause of the problem is that when the teacher is referred, the referTeachersUniteVolunteer function is called to send the data the backend without saving the personalDetails in the onyx.

However, unlike the addSchoolPrincipal function, the referTeachersUniteVolunteer function doesn't optimistically add the personalDetails of the referred teacher in the onyx.

Furthermore, the response from the backend in the report action only includes <mention-user accountID=\"17571571\"\/> in the message without sending back the personalDetails like below.

Therefore, when the accountID is not found in the personalDetails, it shows "Hidden".

Only, when the OpenReport API is called is when the personalDetails of the referred teacher is synced with the onyx.

What changes do you think we should make to solve the problem?

We should make the referTeachersUniteVolunteer function consistent with the addSchoolPrincipal function by optimistically adding the referred teacher's personalDetails in the onyx.

This will also improve the offline experience when a teacher is being referred when the user is offline.

Therefore, the optimisticData, successData, and failureData should look like the addSchoolPrincipal function, mainly the personalDetails to avoid the new accountID from showing "Hidden", since the user's data it is not found in the personalDetails.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0106b42c9c00ea9afa

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot[bot]]

@greg-schroeder, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

[greg-schroeder]

Bump on proposal review @rushatgabhane

[rushatgabhane]

I like @Tony-MK's proposal https://github.com/Expensify/App/issues/43846#issuecomment-2175692058

[rushatgabhane]

🎀👀🎀

[melvin-bot[bot]]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[muttmuure]

This is not a #newdot-quality bug - the feature is not unreliable, slow or performing redundant or unexpected API calls, it just doesn't work as designed

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@youssef-lr @greg-schroeder @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@youssef-lr, @greg-schroeder, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

@youssef-lr, @greg-schroeder, @rushatgabhane 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[greg-schroeder]

@youssef-lr can you confirm the contributor assignment here?

[greg-schroeder]

I believe that is this one: https://github.com/Expensify/App/issues/43846#issuecomment-2190208844

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸