Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.12k stars 2.61k forks source link

[$125] iOS - Distance - Top left corner of the distance receipt is sharp instead of rounded #43848

Open lanitochka17 opened 2 weeks ago

lanitochka17 commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.84-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4638881 Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to workspace chat
  3. Submit a distance expense
  4. Go to transaction thread
  5. Tap on the distance receipt

Expected Result:

The receipt corner on all ends should be rounded

Actual Result:

The top left corner of the distance receipt is sharp and not rounded

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

IMG_4383

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e67d7fccfba02aee
  • Upwork Job ID: 1803175323249438423
  • Last Price Increase: 2024-07-02
Issue OwnerCurrent Issue Owner: @parasharrajat
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 2 weeks ago

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 2 weeks ago

We think that this bug might be related to #wave-collect - Release 1

Krishna2323 commented 2 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Distance - Top left corner of the distance receipt is sharp instead of rounded

What is the root cause of that problem?

Seems like issue in react native. The documentation suggests using overflow: hidden incase of border radius not working.

What changes do you think we should make in order to solve the problem?

Add overflow: hidden to eReceiptPanel style object. https://github.com/Expensify/App/blob/a67e55d7eb1cf5fbe316255781287f516c5187cd/src/styles/index.ts#L3970-L3977

What alternative solutions did you explore? (Optional)

Monosnap iPhone 15 Pro Max 2024-06-17 22-17-23
Krishna2323 commented 2 weeks ago

Proposal Updated

dylanexpensify commented 2 weeks ago

reproing today!

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~01e67d7fccfba02aee

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

dylanexpensify commented 2 weeks ago

Made external

melvin-bot[bot] commented 2 weeks ago

Upwork job price has been updated to $125

dylanexpensify commented 2 weeks ago

updated price given the ease of this

parasharrajat commented 2 weeks ago

@Krishna2323's proposal looks good to me.

:ribbon: :eyes: :ribbon: C+ reviewed

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

dylanexpensify commented 2 weeks ago

@roryabraham to review and confirm!

parasharrajat commented 1 week ago

Bump @roryabraham

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 week ago

@parasharrajat, @roryabraham, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

parasharrajat commented 1 week ago

This is a small issue, let's keep this moving. @dylanexpensify @roryabraham

melvin-bot[bot] commented 6 days ago

@parasharrajat @roryabraham @dylanexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 6 days ago

@parasharrajat, @roryabraham, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

parasharrajat commented 5 days ago

Just waiting on Enginner to review this. cc @dylanexpensify

melvin-bot[bot] commented 5 days ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

parasharrajat commented 5 days ago

@roryabraham need your review.

parasharrajat commented 3 days ago

@dylanexpensify Looks like Rory is not available. Could you please reassign this issue?

dylanexpensify commented 3 days ago

Will bump @roryabraham