Open arosiclair opened 2 months ago
Job added to Upwork: https://www.upwork.com/jobs/~01cc92666d46e99569
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External
)
Triggered auto assignment to @puneetlath (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:
Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature
)
weekly update: Still held on https://github.com/Expensify/App/issues/44015
Not held on https://github.com/Expensify/App/issues/44015 anymore.
Everything's deployed so this should be all set
Woops wrong issue 😅
I posted https://github.com/Expensify/Integration-Server/pull/8040 to fix the issue with errors in manual sync jobs not getting pushed to NewDot. I also noticed another issue with successful sync data not getting pushed and posted https://github.com/Expensify/Auth/pull/11925 to fix it. Hopefully we can get these out in the next couple days.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
https://github.com/Expensify/App/pull/45251 is merged and on its way to staging.
Triggered auto assignment to @muttmuure (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
I believe this will only need payment for @hungvu193's C+ reviews on these two PRs:
but that's after deploy and the regression period.
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.23-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-29. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression test:
Prerequisites:
Steps:
Change integration:
Based on the scope that was added to https://github.com/Expensify/App/pull/45251, Can I request a raise for the bounty of this issue 😄 ?
@arosiclair, @hungvu193, @muttmuure Huh... This is 4 days overdue. Who can take care of this?
reviewing this tomorrow
How many PRs did you review in total?
We have 2 PRs:
The first one (https://github.com/Expensify/App/pull/45251) is a big PR, and we also added a lot of reactors to reuse the code.
Would $750 be about right?
Yes. Lovely 💪
Part of QBO Export and Error Handling in NewDot
Main issue: https://github.com/Expensify/Expensify/issues/350150 Doc section: https://docs.google.com/document/d/1aQl-AK_F6IqszWYG2aEllTsD5x3h4b8Zu0XEG0LuQ08/edit#heading=h.pmmx5zp5s75j Project: #wave-collect
Feature Description
As described in the doc, we need to display a RBR when there are errors in a policy connection’s last sync.
The RBR will show on the path to the integration connection settings (Avatar > Workspaces > [Workspace name] > Accounting > Connections):
When the error is a credentials error (policy.connection.lastSync.isAuthenticationError is true), we’ll replace the ‘Sync now’ option in the connection’s 3-dot menu with a ‘Reconnect’ option here. The option will restart the Quickbooks Auth flow as described in our initial QBO doc.
Manual Test Steps
Prerequisites
Steps
Automated Tests
errorMessage
andisAuthenticationError
are set on the IntegrationLastSyncSavePolicy
verifying that anINTEGRATIONSMESSAGE
action gets posted to the #admins room when the last sync is a failureUpwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @muttmuure