[$250] mWeb/Safari - Navigation - After inviting a member navigating back takes you back to members page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-6 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

1. Go to Workspace > Members
2. Invite a member
3. On the members page click the back button on top
4. Notice you are navigated to the workspace page
5. Now click the back button found on the workspace page Notice you are returned to the members page again

Expected Result:

Clicking back takes you to the Workspace list page

Actual Result:

Clicking the back button returns you to the members page again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [x] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/2167582e-951d-414d-aa9d-e7f8f45523c9

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d265064621c334d0
• Upwork Job ID: 1805278189475123074
• Last Price Increase: 2024-06-24
• Automatic offers:
• truph01 | Contributor | 102913998

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot[bot]]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking the back button returns you to the members page again

What is the root cause of that problem?

• After clicking on "Invite" button in WorkspaceInviteMessagePage, we call: https://github.com/Expensify/App/blob/29e4c5488d3feafae3bdc20a424628b21831dc88/src/pages/workspace/WorkspaceInviteMessagePage.tsx#L117-L118 leads to there are two CentralPaneNavigator in the route stacks.

• So when we navigate back, it takes we back to member page.

  What changes do you think we should make in order to solve the problem?

• We can update: https://github.com/Expensify/App/blob/29e4c5488d3feafae3bdc20a424628b21831dc88/src/pages/workspace/WorkspaceInviteMessagePage.tsx#L117-L118 to:

      Navigation.dismissModal()

  What alternative solutions did you explore? (Optional)

[zanyrenney]

tried on web, can't repro but i think this is just on safari. mobile web as per the desc.

[zanyrenney]

Adding external to investigate!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01d265064621c334d0

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[zanyrenney]

hey @Pujan92 please explore the proposal above from @truph01 !

[Pujan92]

Thanks @zanyrenney, I will review the proposal max by tomorrow.

[Pujan92]

leads to there are two CentralPaneNavigator in the route stacks.

@truph01 Can you plz explain again to help me understand your RCA

[truph01]

• When we call Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(route.params.policyID)) in: https://github.com/Expensify/App/blob/29e4c5488d3feafae3bdc20a424628b21831dc88/src/pages/workspace/WorkspaceInviteMessagePage.tsx#L117-L118, the action in this: https://github.com/Expensify/App/blob/5e464eaa3e7614e6f17007e05203e184c275faf2/src/libs/Navigation/linkTo/index.ts#L216 will be:

  
  {
  "type": "PUSH",
  "payload": {
      "name": "FullScreenNavigator",
      "params": {
          "initial": true,
          "screen": "Workspace_Members",
          "params": {
              "policyID": "66A1FB0AB335B7F2"
          },
          "path": "/settings/workspaces/66A1FB0AB335B7F2/members"
      }
  }
  }

- As you can see, the new ```FullScreenNavigator``` is added to the stacks.

- Note that, in my proposal, I wrote (my bad):

> leads to there are two CentralPaneNavigator in the route stacks.

but it should be:

> leads to there are two FullScreenNavigator in the route stacks.

[Pujan92]

Thanks @truph01, I think we can proceed with @truph01's proposal to dismiss the modal instead of navigating to the members page which leads to pushing the second FullScreenNavigator.

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[truph01]

@Pujan92 PR https://github.com/Expensify/App/pull/44668 is ready

[Pujan92]

@zanyrenney can we assign a new internal engineer to review PR as I think @thienlnam is OOO until 8th July?

[thienlnam]

Merged

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @Pujan92, @thienlnam, @zanyrenney, @truph01 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[Pujan92]

Regression Test Steps

1. Go to Workspace > Members and invite a member
2. After inviting, you will be landed on the members page
3. Click back button and it will navigate to the workspace details page
4. Now again click the back button
5. Verify that you are navigated to Workspace list page and it doesn't take you to the members page

[Pujan92]

@zanyrenney Bump for the payment

[zanyrenney]

Thanks @Pujan92

[zanyrenney]

payment summary

paid $250 to @truph01 via Upwork. @Pujan92 is owed $250 (paid via ND) - please request.

[JmillsExpensify]

$250 approved for @Pujan92