[$250] Workspace - Hidden Appears in members when clicking "Invite Members" button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-6 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): betlihemasfaw14@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Sign in with a new account > Account Settings
2. Navigate to Workspace > Create Workspace > Go to Members > Click "Invite Members" button

Expected Result:

No hidden text should appear when clicking the "Invite Members" button

Actual Result:

Notice that the text "Hidden" briefly appears inside the Members section

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/36959114-4f27-4041-8d85-ddf9ac452004

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bf54cdd699edddd6
• Upwork Job ID: 1803821385140635715
• Last Price Increase: 2024-06-27

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot[bot]]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[OfstadC]

I'm not able to reproduce

[OfstadC]

Ope! After I navigated away from the page, and came back, "Hidden" was listed and stuck 😬 Staging & Production

[OfstadC]

Simplified Collect (new Workspace settings pages e.g categories, members taxes, workflows etc)

Based on this, I believe this is #wave-collect

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01bf54cdd699edddd6

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is text "Hidden" appears on Member section after click "Invite Members" button

What is the root cause of that problem?

There is another user with accountId 0 after click "Invite Members" button

What changes do you think we should make in order to solve the problem?

Don't add the data to member list data if accountId equals to 0 on getUsers function

https://github.com/Expensify/App/blob/5158966f278353b86b2d26c8f3d3edb0810b4e49/src/pages/workspace/WorkspaceMembersPage.tsx#L307

What alternative solutions did you explore? (Optional)

Filter member list data to exclude member with name == 'Hidden' on getUsers function

[Pujan92]

Thanks for the proposal @nyomanjyotisa. Your RCA seems to be incomplete where we also have to find out why the other user has been assigned the accountId 0. Regarding your solution I don't think we need to filter out accountID with the value 0 specifically.

To reproduce we don't need to click on Invite Members, it will be seen once we navigate to the Members page after creating the workspace for the new account.

[OfstadC]

Any updates here? 😃

[Pujan92]

Looking for more proposals as I am not yet fully convinced with @nyomanjyotisa's proposal.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[OfstadC]

Since this isn't critical, I don't think we need to raise the bounty ...

[abzokhattab]

Cannot reproduce it.

[Pujan92]

Thanks @abzokhattab, Yes it is not reproducible now as CreateWorkspace API returns the workspace manager details within personaDetailsList which isn't received earlier.

@lanitochka17 Plz retest and confirm.