Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.43k stars 2.8k forks source link

[HOLD for payment 2024-07-10] Android - Composer - Suggestion list appears amid report view after sending multiline text #44077

Closed m-natarajan closed 2 months ago

m-natarajan commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.86-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Open any chat.
  3. Tap on the composer.
  4. Create many new lines until the composer is scrollable.
  5. Enter @ and select a user from the list.
  6. Send the message.
  7. Enter @.

Expected Result:

The mention list will appear above the cursor.

Actual Result:

The mention list appears in the middle of the report view.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/0ca6d03b-b28e-469e-b8d5-2ce96068f428

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @MitchExpensify
melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 3 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
m-natarajan commented 3 months ago

@grgia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

m-natarajan commented 3 months ago

We think that this bug might be related to #vip-vsb

mountiny commented 3 months ago

This also seems related to https://github.com/Expensify/App/pull/42630 @perunt @puneetlath

mountiny commented 3 months ago

Doming from here https://expensify.slack.com/archives/C035J5C9FAP/p1718916284226989 demoting and @perunt can handle this once online

perunt commented 3 months ago

fixed will add screen records in a couple of minutes

grgia commented 3 months ago

Thank you @perunt !

melvin-bot[bot] commented 3 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.3-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. :confetti_ball:

melvin-bot[bot] commented 3 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

MitchExpensify commented 3 months ago

Payment summary:

Does this look alright to you?

perunt commented 2 months ago

I'm from the Margelo agency, and we get our payments separately, so all good

melvin-bot[bot] commented 2 months ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

MitchExpensify commented 2 months ago

Cool, closing as the only payment needed is via NewDot

JmillsExpensify commented 2 months ago

$250 approved for @sobitneupane