Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.43k stars 2.8k forks source link

[$250] Group chat – Group avatar photo changes to default after relogin #44083

Closed lanitochka17 closed 1 month ago

lanitochka17 commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.86-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+jp_e_category_1@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Create a group and upload avatar photo
  4. Log out
  5. Log in with the same account and find a group in LHN

Expected Result:

Group chat is with photo avatar

Actual Result:

Group avatar photo changes to default after relogin. Photo appears when open the group chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/e6375188-73b4-4204-b52c-dff6decf0c7a

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011b1f3bc6eeb8016f
  • Upwork Job ID: 1803874883740630335
  • Last Price Increase: 2024-06-20
melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 3 months ago

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 3 months ago

We think that this bug might be related to #vip-vsp

melvin-bot[bot] commented 3 months ago

Job added to Upwork: https://www.upwork.com/jobs/~011b1f3bc6eeb8016f

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

melvin-bot[bot] commented 3 months ago

📣 @devalirzayev! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
devalirzayev commented 3 months ago

@suneox This needs internal reviewing.

Please see screenshot. Selected report (which is group chat) has avatarUrl and returns when opened (OpenReport endpoint) but in OpenApp endpoint it does not.

image

suneox commented 3 months ago

I'll check it today

suneox commented 3 months ago

@suneox as I have stated this is backend bug. Needs internal reviewing.

@devalirzayev Thank for your investigate. I have double-checked, and I agree with you that is a BE issue. When first login OpenApp return avatarUrl is empty.

🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 3 months ago

@yuwenmemon, @suneox, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

greg-schroeder commented 3 months ago

Okay so this is going to require an internal engineer, will set as Hot Pick as root cause was determined

melvin-bot[bot] commented 3 months ago

@yuwenmemon @suneox @greg-schroeder this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

greg-schroeder commented 2 months ago

Still waiting for an internal engineer to pick this up

greg-schroeder commented 2 months ago

Same as above

suneox commented 2 months ago

Still waiting for an internal fix.

greg-schroeder commented 2 months ago

Same as above

greg-schroeder commented 1 month ago

Same as above

suneox commented 1 month ago

This issue will be handled by the internal team, so I’d like to self-unassign

greg-schroeder commented 1 month ago

Still waiting for an internal engineer to take on

greg-schroeder commented 1 month ago

Same as above

yuwenmemon commented 1 month ago

I'm not able to reproduce this on dev or prod - has anyone been able to? Screenshot 2024-09-04 at 11 03 49 PM Screenshot 2024-09-04 at 11 04 36 PM Screenshot 2024-09-04 at 11 04 33 PM assets/4072be9f-0561-4ef2-bf57-a242fe2c164e) Screenshot 2024-09-04 at 11 06 16 PM

yuwenmemon commented 1 month ago

In fact, I see the avatarUrl for the Group in the OpenApp response when retesting this: Screenshot 2024-09-04 at 11 11 54 PM

So I'm going to call this fixed and close it out.