Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.14k stars 2.64k forks source link

[$250] [$250 Reproduction Steps] There are chats in the LHN and could not be removed #44108

Closed m-natarajan closed 3 days ago

m-natarajan commented 4 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @danielvidal Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1718638249114319

Deliverable

The job is open to proposals. If someone is able to provide reliable reproduction steps, compensation will be $125.

Action Performed:

  1. Have a old workspace chat that are submitted and paid by the approver

Expected Result:

These very old expenses (archived chats)from months ago shouldn't appear in the LHN

Actual Result:

These very old expenses from months ago that re-appeared on the LHN out of nowhere

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

image (14) image (15)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019968f6b9ea37c469
  • Upwork Job ID: 1804224013010140122
  • Last Price Increase: 2024-07-12
melvin-bot[bot] commented 4 weeks ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 4 weeks ago

Triggered auto assignment to @techievivek (AutoAssignerNewDotQuality)

MelvinBot commented 4 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

melvin-bot[bot] commented 4 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~019968f6b9ea37c469

melvin-bot[bot] commented 4 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

mallenexpensify commented 4 weeks ago

Nipping this one in the bud a bit cuz I have a strong feeling it's going to be hard to reproduce. Added to OP

Deliverable

The job is open to proposals. If someone is able to provide reliable reproduction steps, compensation will be $125.

kadiealexander commented 3 weeks ago

@quinthar also reported this happening here.

srikarparsi commented 3 weeks ago

This also happens when a workspace member leaves a workspace. Their workspace chat becomes permanently unread. So:

  1. Account A: Create a workspace
  2. Account A: Add a member (Account B)
  3. Account B: Leave the workspace
  4. Account A: See that the Account B's workspace chat is permanently unread

But @kadiealexander reported that she didn't leave the workspace and instead BulkUnsharePolicies.php was used which causes sharePolicy. But I believe leavePolicy also eventually calls sharePolicy so there might be something related there? I don't think I'll be able to take over assignment @techievivek because I have a lot on my plate currently and I just got assigned a new NewDot reliability issue but I'll stay subscribed so that I might be able to help out since I've been doing some work with deletePolicy which is kind of related with archived reports.

I'm also not sure why I'm able to reliably produce this when leaving a workspace but this only occurred for @kadiealexander's workspace chat and not the others that were removed using BulkUnsharePolicies.php. Also cc @MonilBhavsar and @marcaaron if you guys have any ideas.

melvin-bot[bot] commented 3 weeks ago

@danielrvidal, @mallenexpensify, @allroundexperts, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

techievivek commented 3 weeks ago

I will try to reproduce this based on Srikar's comment here https://github.com/Expensify/App/issues/44108#issuecomment-2186903100

techievivek commented 3 weeks ago

Not overdue, still needs to reproduce this before we can move forward.

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 3 weeks ago

@danielrvidal, @mallenexpensify, @allroundexperts, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

danielrvidal commented 3 weeks ago

This is still in my account so let me know if anyone needs to hop on a screen share with me to help diagnose. I've also logged in and out since reporting it so it seems persistent.

muttmuure commented 2 weeks ago

Main tracking issue here: https://github.com/Expensify/App/issues/44683

melvin-bot[bot] commented 2 weeks ago

@danielrvidal, @mallenexpensify, @allroundexperts, @techievivek 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

techievivek commented 2 weeks ago

I was unable to reproduce this issue after several attempts. Let me ask Applause to try reproducing it based on the steps mentioned here: https://github.com/Expensify/App/issues/44108#issuecomment-2186903100.

techievivek commented 2 weeks ago

Bumped for a retest here https://expensify.slack.com/archives/C9YU7BX5M/p1720076939828249?thread_ts=1720018115.897109&cid=C9YU7BX5M

kavimuru commented 2 weeks ago

Unable to reproduce

https://github.com/Expensify/App/assets/43996225/67f46c54-35cb-4025-a4b1-fe01e5865b0d

melvin-bot[bot] commented 2 weeks ago

@danielrvidal @mallenexpensify @allroundexperts @techievivek this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 2 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

techievivek commented 1 week ago

@danielrvidal @mallenexpensify I am unable to reproduce this on my end, and the QA team was also unsuccessful in reproducing the issue https://github.com/Expensify/App/issues/44108#issuecomment-2208838706. What is the best way to move forward here?

mallenexpensify commented 1 week ago

Raised price for reproduction steps to $250 and posted in #expensify-open-source https://expensify.slack.com/archives/C01GTK53T8Q/p1720484027137579

srikarparsi commented 1 week ago

@hurali97 seemed to have reproduced it here. Do you think you could lay out the reproduction steps? I think @techievivek can also assign you to this issue if you want to work on this.

techievivek commented 1 week ago

Yeah, I can work on it, just waiting for clear reproduction steps.

muttmuure commented 1 week ago

Asked Ali to take a look from CS. It's possible that this is a dupe

hurali97 commented 1 week ago

@srikarparsi We have a PR out here which fixes the issue where user was unable to mark a chat as read.

I just have one question, reading through the conversation it looks like there are two separate issues:

The linked PR fixes only the first issue but not the second one as it is addressing this issue specifically.

Let us know if we are on the same page here. If we are, then @rinej maybe able to work on the second issue from Monday.

muttmuure commented 1 week ago

@techievivek I think the question is for you too

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

techievivek commented 5 days ago

@hurali97

Some chats shouldn't appear in LHN but they are appearing anyway

The second point you've listed is the problem here. There are some chats that appeared unexpectedly. Srikar provided these steps to reproduce the bug, but I wasn't able to reproduce the issue following those steps.

mallenexpensify commented 4 days ago

Went down a 🐰🕳 trying to test (and cleaning up LHN in my test account) and wasn't able to reproduce.

danielrvidal commented 4 days ago

I still have the chat with Kadie in my LHN if it helps. Let me know if anyone wants me to do anything to diagnose. image

Here is my Onyx State. onyx-state.txt

puneetlath commented 3 days ago

I think this is a dupe of https://github.com/Expensify/App/issues/44693 so I'm going to close this. But please reopen if I'm mistaken.