search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.12k stars 2.61k forks source link

[Payment Card / Subscription] iOS - "Add Payment Card" button is blinking when changing currency in app #44118

Closed lanitochka17 closed 1 day ago

lanitochka17 commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.86-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): emilio.utest@gmail.com Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/43317

Action Performed:

  1. Access the New Expensify Beta app
  2. Sign into a valid account
  3. Go to staging.new.expensify.com/settings/subscription/add-payment-card (You may need a beta access account to locate this page)
  4. Change the currency and observe the bottom green button

Expected Result:

User expects the button to stay normal when changing currency

Actual Result:

The button is flashing when the currency is changed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/fc65333f-2d66-4401-85c5-455a721775fd

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @narefyev91
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mountiny commented 2 weeks ago

@fabioh8010 this is still behind beta so not a blocker but should be handled

mountiny commented 2 weeks ago

Raised in Slack

trjExpensify commented 2 weeks ago

@fabioh8010 this is still behind beta so not a blocker but should be handled

FYI, there's no beta for this. It's only accessible if you know the URL though, so effectively hidden. :)

narefyev91 commented 2 weeks ago

Hey! I'm Nicolay from Callstack - will work on this flow - please assign it for me. Thanks!

trjExpensify commented 2 weeks ago

Assigned!

blimpich commented 2 weeks ago

Picking this up as I'm managing the other issues that are being addressed by this PR, figured I should pick this up too.

melvin-bot[bot] commented 1 week ago

@blimpich, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 1 week ago

@blimpich, @narefyev91 Huh... This is 4 days overdue. Who can take care of this?

blimpich commented 1 week ago

not overdue, PR was merged, waiting auto-close

melvin-bot[bot] commented 5 days ago

@blimpich, @narefyev91 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

melvin-bot[bot] commented 3 days ago

@blimpich, @narefyev91 10 days overdue. Is anyone even seeing these? Hello?

melvin-bot[bot] commented 1 day ago

@blimpich, @narefyev91 12 days overdue. Walking. Toward. The. Light...

blimpich commented 1 day ago

Closing as the fix for this reached production.