[Awaiting Payment Sept 9th] [$250] Xero - "Can't connect to Xero." error message appears briefly before connecting

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.86-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4653112&group_by=cases:section_id&group_id=309134&group_order=asc Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with a new expensifail account
3. Create a workspace
4. Enable Accounting
5. Navigate to Workspace settings - Accounting
6. Connect to Xero

Expected Result:

I should be able to connect without any error messages

Actual Result:

"Can't connect to Xero." error message appears briefly before connecting. Affects Gmail and expensifail accounts too.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/943516af-d8e7-4e96-90d1-e5d13ecbba40

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c4b2bfe4b91b5ac9
• Upwork Job ID: 1805137190641025234
• Last Price Increase: 2024-08-08
• Automatic offers:
• alitoshmatov | Reviewer | 103274174

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot[bot]]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01c4b2bfe4b91b5ac9

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot[bot]]

@kadiealexander, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alitoshmatov]

Waiting for proposals

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@kadiealexander, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alitoshmatov]

Still waiting for proposals

[melvin-bot[bot]]

@kadiealexander @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@kadiealexander, @alitoshmatov Eep! 4 days overdue now. Issues have feelings too...

[kadiealexander]

Requested a retest here.

[kbecciv]

Reproducible on build 9.0.5-7.

https://github.com/Expensify/App/assets/93399543/cc9b16b6-0d33-4832-8295-21dcd9f1b343

[kadiealexander]

Still not overdue.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@kadiealexander, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kadiealexander]

Not overdue.

[kadiealexander]

I can still reproduce:

https://github.com/user-attachments/assets/fd0fd920-6ddf-4004-a70e-9bcf04d60277

@alitoshmatov do you think this can be fixed entirely on the front end?

[melvin-bot[bot]]

@kadiealexander @alitoshmatov this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@kadiealexander, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kadiealexander]

@alitoshmatov bump on my question above.

[kubabutkiewicz]

Hi! I am Jakub from Callstack - expert contributor group. I’d like to work on this issue.

@kadiealexander Can I get some credentials to connect to Xero? And are there any other requirements to reproduce that issue?

[kadiealexander]

Hi Jakub! That's all that is needed to reproduce. Do you have access to our 1password environment?

[melvin-bot[bot]]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[kubabutkiewicz]

@kadiealexander no, I dont have

[trjExpensify]

@kubabutkiewicz try to connect to Xero and then choose the Xero demo company option.

[trjExpensify]

I'm not sure if that option is there anymore, but if not.. just start a 30 day free trial: https://www.xero.com/uk/signup/

[trjExpensify]

Also, @nkdengineer @brunovjk as you guys worked on this PR very recently, I'm curious for your thoughts here as well: https://github.com/Expensify/App/pull/45041

[kubabutkiewicz]

Hi ! @trjExpensify thanks for that I was able to reproduce that. For me this seems to be a problem with syncing with backend. So the logic for showing red brick road indicator is that we finished syncing and policy connection isSuccessful is false so it look like that !isSyncInProgress && policy?.connections?.[connectionName]?.lastSync?.isSuccessful === false. And for isSyncInProgress we are checking that POLICY_CONNECTION_SYNC_PROGRESS onyx key have stageInProgress property different than jobDone value. The problem is happening when stageInProgress is jobDone but in policy looks like that

{
    connections: {
        xero: {
            lastSync: {
                isSuccessful: false
            }
        }
    }
}

So stageInProgress is changing quicker to jobDone than changing isSuccessful to true. So there is somewhere reace condition I guess. Do we have any other indicator that syncing is still in progress? and do we know what is this key isConnected in xero.lasySync object ? As its always set to false

[trjExpensify]

@lakchote is out, but I think this might be related: https://github.com/Expensify/App/issues/46445#issuecomment-2257209333

CC: @yuwenmemon @NikkiWines (@aldo-expensify as well for vis).

[kubabutkiewicz]

Hey hey, during debugging I noticed different bug. When I was redirected to Xero page and when clicked Allow access I got 500 error during redirect back to Expensify which looked like that

But on Connections page it looks like I am connected but the Onyx data looks like I shouldn't be connected

[kubabutkiewicz]

The problem here is that backend sometimes sending pusher events in different order. At the first screenshot we see that first pusher event is for policyConnectionSyncProgress which says that its jobDone is sent before policy object which says isSuccessful: true but on the second screenshot that the order of those two messages is opposite, and this is making this issue. So in my opinion we should make that backend will sent those messages always in the same order. Because policyConnectionSyncProgress is our indicator that syncing is still in progress or no.

[trjExpensify]

Is the bug still reproducible now @NikkiWines's IS PR is on prod?

[kadiealexander]

Requested a retest here

[kavimuru]

Bug is still reproducible.

https://github.com/user-attachments/assets/2b7cae6b-b854-4a7f-812d-77a91888ad57

[trjExpensify]

Interesting, @kubabutkiewicz did you get this TypeError like QA did?

[kubabutkiewicz]

I will check it @trjExpensify but did you saw my message before ?https://github.com/Expensify/App/issues/44148#issuecomment-2260056390

[trjExpensify]

Right, but I don't recall you mentioning the TypeError for target and I'm wondering if that's an "evolution" of the bug, since @NikkiWines's IS changes.

[kubabutkiewicz]

@trjExpensify Right now for me connecting to Xero is not working at all 🤔 is it a known issue?

https://github.com/user-attachments/assets/cc01a1f2-e25c-4e71-95b0-f4be1e7848bc

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[trjExpensify]

Ah, @hungvu193 you've run into this 500 before right?

[hungvu193]

Ah, @hungvu193 you've run into this 500 before right?

Yep, but I can't reproduce it now

[trjExpensify]

IIRC, you resolved it by disconnecting or something?

[hungvu193]

Yeah, I disconnected and reconnected again. Also this bug Xero - "Can't connect to Xero." error message appears briefly before connecting also happened on SageIntacct. I faced it while testing https://github.com/Expensify/App/pull/45251 I mentioned it here

[trjExpensify]

You mean also happened with QBO, right? Yup, we should discuss somewhere in realtime to get to the bottom of it: https://expensify.slack.com/archives/C036QM0SLJK/p1723545827358999?thread_ts=1723483552.155049&cid=C036QM0SLJK

[hungvu193]

You mean also happened with QBO, right?

Ah yes. My bad

[hungvu193]

I agree with @kubabutkiewicz 's comment, we should fix this from BE. cc @arosiclair