Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.12k stars 2.62k forks source link

[HOLD for payment 2024-07-17] [Details Revamp] Allow Editing Report Title from Details Page #44149

Open grgia opened 2 weeks ago

grgia commented 2 weeks ago

Problem

image

We currently display the report title as shown above. This is now inconsistent with our new details revamp project.

Solution

image

Make the report title editor available from the details page for those with correct permissions. Remove it from the report body as shown in the previous screenshot.

So for example, members, approvers and admins can change the report title. Anyone added to the room, not part of the approval workfllow, should not be able to change the report title.

We will use our typical push to page pattern for this change.

Slack thread

https://expensify.slack.com/archives/C036QM0SLJK/p1718830874704809?thread_ts=1718719187.256049&cid=C036QM0SLJK

Issue OwnerCurrent Issue Owner: @kadiealexander
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

cdOut commented 2 weeks ago

Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’ll be working on this issue.

ishpaul777 commented 2 weeks ago

I am low on issues, just incase we need a c+ for this issue i'd love to help

trjExpensify commented 2 weeks ago

Assigning @ishpaul777 for C+.

melvin-bot[bot] commented 2 days ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 2 days ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 6 hours ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 6 hours ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 6 hours ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: