Open roryabraham opened 4 months ago
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
cc @francoisl since we talked about this yesterday
the PR is automatically opened not by OSBotify but by the Expensify employee who triggered the CP. That way, tests and lint run as normal.
I dealt with this on GH Actions, basically if you create a PR in a GH Action, it will not run tests.
Problem
When we cherry-pick PRs, we have
OSBotify
attempt to automatically cherry-pick the code (and resolve certain conflicts automatically). When he can successfully do that, it works great because he can push that code straight to staging without the need for a pull request.However, in cases where we need to manually resolve conflicts,
OSBotify
will commit the conflict markers (weird, right?) then open a PR, and assign it to the person who triggered the CP to resolve the conflicts and get the PR reviewed and merged.However, PRs created by
OSBotify
,imgbot
, and other bots have tests and lint skipped, so we lose that bit of security on manual CPs.Solution
Two parts:
OSBotify
but by the Expensify employee who triggered the CP. That way, tests and lint run as normal.