[$250] Task – Green dot disappears in task LHN after reopen if reassign owned task

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4661811 Email or phone of affected tester (no customers): applausetester+jp_category_1@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Create a task without an assignee in a 1:1
4. Verify the green dot is not displayed in the task conversation in LHN
5. Assign the task to yourself
6. Verify there's a green dot in the Task conversation in LHN
7. Reassign the task to the other DM participant
8. Observe the task in LHN

Expected Result:

Green dot disappears in LHN when reassign task to another user

Actual Result:

Green dot disappears when reopened task

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/e243b412-f383-4994-b20c-2ee2cbf2bce3

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dc8764b9cb373554
• Upwork Job ID: 1805605172221647090
• Last Price Increase: 2024-07-09

Issue Owner

Current Issue Owner: @mollfpr

[melvin-bot[bot]]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[bernhardoj]

My proposal here covers this issue too (which requires BE fix too)

[zanyrenney]

adding external

[zanyrenney]

added to VIP VSB.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01dc8764b9cb373554

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot[bot]]

@mollfpr, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[grogou]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green dot indicator in the LHN not disappearing when the task assignee is changed.

What is the root cause of that problem?

When the editTaskAssignee function assigns a report and receives a response from the backend, the lastReadTime date of the report is not updated.

This leads to an issue in the isUnreadWithMention function, which determines whether to display the green dot indicator. The function returns true if lastReadTime is less than lastMentionedTime. So, after reassigning a report to another user, the report still shows as unread because the lastReadTime remains outdated.

What changes do you think we should make in order to solve the problem?

In the editTaskAssignee function, I've introduced a new parameter, currentReportID. This parameter helps in checking if the report being assigned is the same as the currently focused report. If they match, we update the lastReadTime to the current time.

By doing this, we resolve the issue of the lastReadTime being expired. As a result, the report will no longer be flagged as isUnreadWithMention, and the green dot indicator will disappear as expected.

Changes Made:

• Added currentReportID parameter to editTaskAssignee function.
• Added a check to update lastReadTime if the assigned report matches the current focused report.

Impact:

• Prevents reports from incorrectly appearing as unread after reassignment.
• Ensures the green dot indicator is accurately displayed based on the updated lastReadTime.

Here is an example of the expected result.

https://github.com/Expensify/App/assets/10712881/948917a9-f218-4069-bfed-0f57814e7fa4

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mollfpr]

Will review the proposal tomorrow!

[melvin-bot[bot]]

@mollfpr, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@mollfpr @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@mollfpr, @zanyrenney Still overdue 6 days?! Let's take care of this!