Closed lanitochka17 closed 19 hours ago
Triggered auto assignment to @luacmartins (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Web - Book travel - There is hover effect on "Save money on ..." and "Get realtime updates.."
The background is updated whenever isHovered && !pressed
is true.
https://github.com/Expensify/App/blob/425804aa005c6299ff0f59ff596764c429e19abd/src/components/MenuItem.tsx#L515-L517
We should also check if the item is interactive or not on both places where we update the hover styles.
!focused && interactive && (isHovered || pressed) && hoverAndPressStyle,
shouldGreyOutWhenDisabled && disabled && styles.buttonOpacityDisabled,
isHovered && interactive && !pressed && styles.hoveredComponentBG,
Book travel - There is hover effect on "Save money on ..." and "Get realtime updates.."
Offending PR -https://github.com/Expensify/App/pull/43987/files
Here hover hoveredComponentBG
is applied when isHovered && !pressed
but there is no consideration when component is not interactive
In <Hoverable>
component we can pass a prop isDisabled={!interactive}
to disable hover.
Thanks all for the help here by tagging the offending PR and sharing the insights on the issue. Fixing this issue here at #44219 since this is a regression from #43987 cc @MonilBhavsar
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.1-19 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-02. :confetti_ball:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Payment will be handled in https://github.com/Expensify/App/issues/41901. Closing.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.1-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4661870 Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
There will be no hover effect on "Save money on your bookings" and "Get realtime updates and alerts" (production behavior)
Actual Result:
There is hover effect on "Save money on your bookings" and "Get realtime updates and alerts"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/655bed1e-4483-416b-b9ae-12f251bcfcee
View all open jobs on GitHub