Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.87k forks source link

[$500] Transaction details appear at top of “batched” report #44226

Closed m-natarajan closed 2 months ago

m-natarajan commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: needs reproduction (unable to reproduce) Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719074664086269

Action Performed:

  1. As a employee submit several expenses report to a collect workspace chat
  2. As approver, open the report

    Expected Result:

    The “batched” report shows a total and title up top, nothing else should display

    Actual Result:

    Empty transaction details appear for amount, description, etc. No report title of total appears URL is incorrect https://staging.new.expensify.com/r/1143020388543386/5408340067701095833 and also wrong result with https://staging.new.expensify.com/r/1143020388543386

    Workaround:

    unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop

Screenshots/Videos

CleanShot 2024-06-22 at 10 44 07@2x

CleanShot 2024-06-22 at 10 57 49@2x

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0106429d3635864e62
  • Upwork Job ID: 1806785722278577999
  • Last Price Increase: 2024-08-08
MelvinBot commented 4 months ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

sakluger commented 4 months ago

Asked for clarification around reproduction in Slack.

sakluger commented 4 months ago

Jason showed that this is still reproduceable. Marking as external to get some proposals!

melvin-bot[bot] commented 4 months ago

Job added to Upwork: https://www.upwork.com/jobs/~0106429d3635864e62

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

sakluger commented 4 months ago

No proposals yet.

sakluger commented 4 months ago

Not overdue, waiting for proposals.

sakluger commented 4 months ago

Still no proposals. @allroundexperts - any ideas why there have been no proposals yet? Is this one difficult to reproduce?

allroundexperts commented 4 months ago

Still no proposals. @allroundexperts - any ideas why there have been no proposals yet? Is this one difficult to reproduce?

I was able to reproduce this quite easily. We might want to bump the price to gain more attention.

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 3 months ago

@sakluger @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 3 months ago

Upwork job price has been updated to $500

sakluger commented 3 months ago

I increased the price. Let's see if we get any proposals. If we don't by the end of the week, I'll try recruiting an expert contributor.

mvtglobally commented 3 months ago

Issue not reproducible during KI retests. (First week)

sakluger commented 3 months ago

@allroundexperts are you still seeing this behavior, or is it resolved for you? Raising the price didn't help get any proposals, so if it's still reproducible, I'll ask our expert contributors if they can help.

wasxxm commented 3 months ago

I am not sure about what actual result do you expect, can you annotate the screenshots with the expected result(s)?

Also, how can I act as an employee and as an approver to reproduce the bug in my local dev environment.

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

sakluger commented 3 months ago

@wasxxm - in the two screenshots in the issue description, you can see empty transaction details at the top of the page. In other words, it says "Amount / Description / Merchant / Date" without any values - those items shouldn't be there at all, and instead we should show the total amount owed.

I'm going to ask one of our expert agencies to take a look.

sakluger commented 3 months ago

Actually, before asking agencies - @NikkiWines, I think you worked on the batched report view, right? Do you have any ideas on what might be going on here?

wasxxm commented 3 months ago

So you are not looking for any proposals anymore?

sakluger commented 3 months ago

@wasxxm if you have a proposal, we'd love to see it! I'm just trying to keep the issue moving forward :)

wasxxm commented 3 months ago

how can I act as an employee and as an approver to reproduce the bug in my local dev environment?

sakluger commented 3 months ago

To act as an employee and an approver, you would need two test accounts (A and B).

  1. From account A, create a Control workspace
  2. Enable Workflows (Settings > Workspaces > [workspace name] > More Features > Workflows) and set yourself as the approver
  3. Invite account B as a workspace member
  4. From account B (employee account), sign into Expensify, then create and submit multiple expenses to the workspace
  5. Sign back into account A (approver account) and find the batched report in your LHN.
wasxxm commented 3 months ago

It is not reproducible any more; I am using Google Chrome on a Mac:

image
NikkiWines commented 3 months ago

@NikkiWines, I think you worked on the batched report view, right?

Sorry @sakluger, I didn't work on batched reports, so not sure I'll be of much help here 🙇

mvtglobally commented 3 months ago

Issue not reproducible during KI retests. (Second week)

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 3 months ago

@sakluger @allroundexperts this issue is now 4 weeks old, please consider:

Thanks!

melvin-bot[bot] commented 3 months ago

@sakluger, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?

sakluger commented 3 months ago

Sounds like it's no longer reproducible. Closing for now!

muttmuure commented 3 months ago

@JmillsExpensify is still experiencing this (yesterday) so I'm going to reopen it and assign him

fabioh8010 commented 3 months ago

Hi, I'm Fábio - expert agency contributor - and I would like to work on this issue.

fabioh8010 commented 3 months ago

Started looking into it today.

fabioh8010 commented 3 months ago

After some attempts I'm not being able to reproduce this bug, tested on dev and staging. cc @puneetlath

Am I missing something?

Screenshot 2024-07-29 at 18 01 53

puneetlath commented 3 months ago

Hmm, @JmillsExpensify will know best. Let's chat in the Slack thread.

melvin-bot[bot] commented 3 months ago

@JmillsExpensify, @sakluger, @fabioh8010, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

sakluger commented 3 months ago

Here's the Slack thread where this was being discussed: https://expensify.slack.com/archives/C05LX9D6E07/p1722272792915329?thread_ts=1721348346.978119&cid=C05LX9D6E07

sakluger commented 3 months ago

Commenting again for melvin.

fabioh8010 commented 3 months ago

Update: Still investigating it, I have some ideas of what could be happening

sakluger commented 2 months ago

@fabioh8010 mind dropping an update today? Thanks!

fabioh8010 commented 2 months ago

@sakluger I had to switch to another task last week, I will resume investigations on this one from tomorrow!

fabioh8010 commented 2 months ago

Update: Still investigating it, not able to reproduce, trying to figure out what could cause that weird UI by looking Jason's Onyx data.

melvin-bot[bot] commented 2 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

fabioh8010 commented 2 months ago

Update: Left last investigations on Slack.

melvin-bot[bot] commented 2 months ago

@JmillsExpensify, @sakluger, @fabioh8010, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

sakluger commented 2 months ago

No updates. Fabio said in Slack that he would get back to this one tomorrow.

fabioh8010 commented 2 months ago

Update: Asked another Onyx state data from Jason, it seems that the first one was from web actually, where the issue doesn’t happen. I will now re-analyze report considering this new data file. Just FYI that I’ll be OOO tomorrow and Friday due to bank holidays (as most of CK will be).

sakluger commented 2 months ago

@fabioh8010 should be back online today so hopefully we'll get another update soon.

fabioh8010 commented 2 months ago

Last update here -- thinking about a new strategy to investigate the bug.