Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.16k stars 2.65k forks source link

[HOLD for payment 2024-07-24] Tags - Add GL Code #44257

Open Gonals opened 1 month ago

Gonals commented 1 month ago

From the design doc:

settings/workspaces/{policyID}/tag/{orderWeight}/{tagName}/gl-code -> TagGLCodePage
- Parameter: orderWeight, for multi-level tags it is a number that denotes the order in which we display the tags. tagName, the name of the tag for which we are updating the GL code.
- Calls UpdateTagGLCode
policyID
tagListName - the name of the tagList where the updated tag is
tagListOrderWeight - the index of the tagList. It’ll make it simpler to find the tag in the DB.
tagName - the name of the tag for which we are updating the GL code. Tag name is unique for a given policy so we don’t need to pass orderWeight as an API parameter.
glCode - the updated GL code for the tag.
The pendingAction for the OfflineWithFeedback component will be policyTag.pendingFields?.glCode
Issue OwnerCurrent Issue Owner: @muttmuure
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @muttmuure (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

Gonals commented 1 month ago

@rushatgabhane will be working on this

shawnborton commented 3 weeks ago

What's the latest update here?

Gonals commented 2 weeks ago

The frontend is pretty much ready. Just waiting on the backend PRs to merge

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 1 hour ago

Payment Summary

[Upwork Job]()

BugZero Checklist (@muttmuure)

suneox commented 1 hour ago

I have reviewed the PR and reviewer checklist so can I have any compensation?