[CHECKLIST][HOLD for payment 2024-07-26] Tax - Add tax code

[Gonals]

From the design doc:

settings/workspaces/{policyID}/tax/{taxID}/tax-code -> TaxCodePage
- Parameter: taxID, the ID of the tax rate for which we are updating the tax code.
- Calls UpdateTaxCode
policyID
oldTaxCode - the old tax code for the tax rate.
newTaxCode - the updated tax code for the tax rate.
The pendingAction for the OfflineWithFeedback component will be currentTaxRate.pendingFields?.taxCode

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot[bot]]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot[bot]]

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

[melvin-bot[bot]]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[Gonals]

@rushatgabhane will be working on this

[jliexpensify]

Not overdue

[dangrous]

(adding myself due to review)

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.9-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/43156

If no regressions arise, payment will be issued on 2024-07-26. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[jliexpensify]

Payment summary

• C: @rushatgabhane $250 (New.Dot Payment)
• C+: @mollfpr $250 (New.Dot Payment)

Is a checklist needed?

[mollfpr]

@jliexpensify Sorry, I forget to comment here that I'm reviewers the PR.

[rushatgabhane]

Is a checklist needed

yep

[jliexpensify]

Hi @mollfpr -no problems, I can add you in. So did @rushatgabhane also review? I'm only seeing your name with the PR.

[jliexpensify]

It looks like @rushatgabhane worked on the issue and @mollfpr reviewed the final PR, right?

[rushatgabhane]

yep

[melvin-bot[bot]]

Payment Summary

[Upwork Job]()

• Reviewer: @mollfpr owed $250 via NewDot
• Reviewer: @rushatgabhane owed $250 via NewDot

BugZero Checklist (@jliexpensify)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[jliexpensify]

Awesome, just waiting on the checklist from @mollfpr - payment summary is here.

[JmillsExpensify]

$250 approved for @rushatgabhane

[JmillsExpensify]

$250 approved for @mollfpr

[jliexpensify]

Bumping @mollfpr for the checklist

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR: [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be good!

[@mollfpr] Determine if we should create a regression test for this bug. [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to a control policy
2. Go to taxes page
3. Tap a tax rate
4. Verify that you can see tax code
5. Edit the tax code and save
6. Verify that the tax code is edited and saved
7. 👍 or 👎