search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.12k stars 2.61k forks source link

Review duplicate - "resolved the duplicate" system message disappears after restarting app #44294

Open lanitochka17 opened 1 week ago

lanitochka17 commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.1-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Submit two same expenses (can be manual, scan or distance)
  4. Wait for "Review duplicate" button to show up in transaction thread
  5. Click Review duplicate
  6. Click Keep all
  7. Note that "resolved the duplicate" system message shows up
  8. Go to Troubleshoot > Clear cache and restart > Reset and refresh (or relogin)
  9. Return to the same transaction thread in Step 7

Expected Result:

"Resolved the duplicate" system message will remain

Actual Result:

"Resolved the duplicate" system message disappears after restarting app/relogin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/23f23d63-5036-4e7c-9c3b-36a7b969e739

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
lanitochka17 commented 1 week ago

@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 1 week ago

We think that this bug might be related to #wave-collect - Release 2

rlinoz commented 1 week ago

It looks like we are not sending the action back in the DismissViolation response, so it is not a FE bug, also this is a new feature and I don't think we need to block on this.

image

@pecanoro do you know if this is being handled somewhere else?

pecanoro commented 1 week ago

Hmm, yeah, I don't think we create any report actions for this in the back-end

rlinoz commented 1 week ago

@pecanoro just to be sure, I was reading the doc and we should right? If so, I think we can do that in this issue.

rlinoz commented 1 week ago

Will check in #wave-collect later.

pecanoro commented 1 week ago

Hmm, the problem is that this action can be taken by many people. So the submitter can dismiss it, but the admin will see it either way. I remember discussing it, but I can't remember what we agreed on.

rlinoz commented 1 week ago

Posted on slack

rlinoz commented 4 days ago

Continuing the conversation on slack.