[$250] Update copy based on accounting integration selections

[jamesdeanexpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.1-9 (I'm using Chrome web app staging) Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): james@expensify.com Logs: N/A Expensify/Expensify Issue URL: N/A Issue reported by: james@expensify.com Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1718987997426219?thread_ts=1718837013.444269&cid=C036QM0SLJK

Action Performed:

1. Connect a workspace to QuickBooks Online
2. Click Export > Export company cards as
3. Toggle the options between Credit card and Debit card to see the screen that results (See video below with voiced walkthrough)

Expected Result:

• When Credit card is selected, we should show Credit card account
• When Debit card is selected, we should show Bank account (See video below with voiced walkthrough)

Actual Result:

• When Credit card is selected, we currently show Account
• When Debit card is selected, we currently show Account (See video below with voiced walkthrough)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

• Yes, this is just an improvement

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/22160301/f29a6c2f-3573-4cb8-9570-bf8122b80428

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010acf66c02b3a1adb
• Upwork Job ID: 1806400515559874340
• Last Price Increase: 2024-06-27
• Automatic offers:
• ikevin127 | Reviewer | 102922722
• gijoe0295 | Contributor | 102922724

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot[bot]]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~010acf66c02b3a1adb

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[melvin-bot[bot]]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When Credit card is selected, we currently show Account When Debit card is selected, we currently show Account

Show in both menu title and header title.

What is the root cause of that problem?

This is a copy update feature.

What changes do you think we should make in order to solve the problem?

1. For menu title: Update these 2 copies and change the condition accordingly:

https://github.com/Expensify/App/blob/e0acf6e5a9fe4ec36fe4a0c0f7de36425bb6a583/src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx#L55-L57

Remember to include the vendor_bill >> accountsPayable check as well.

 switch (nonReimbursableExpensesExportDestination) {
    case CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.DEBIT_CARD:
        return translate('workspace.qbo.bankAccount');
    case CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.CREDIT_CARD:
        return translate('workspace.qbo.creditAccount');
    case CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.VENDOR_BILL:
        return translate('workspace.qbo.accountsPayable');
    default:
        return undefined;
}

2. For page header: Update these copies same as above:

https://github.com/Expensify/App/blob/b503938f4d0f24191ab96c9619b39c28631ffd99/src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountSelectPage.tsx#L91-L93

[ikevin127]

@gijoe0295's proposal looks good to me. Root cause is not needed for this issue since it's a copy update Improvement. The proposed solution is enough to move forward with assignment, the below mentions can be handled during PR:

1. The addition of workspace.qbo.creditAccount translation variable for both english and spanish, being Credit card account / Cuenta tarjeta de crédito - make sure to validate the translations (especially for spanish) ⚠️.
2. The switch default case should return translate('workspace.qbo.account') instead of undefined.
3. Since we're using the same function in both components, the function should be reusable (DRY).

Solution video result

https://github.com/Expensify/App/assets/56457735/625078ab-1d0c-4e18-a98a-64b6ee28134f

🎀👀🎀 C+ reviewed

@Beamanator Any idea where should we keep the reusable function mentioned at (3.) since it's used in 2 components ? I did not notice any QBOUtils file or something similar.

[melvin-bot[bot]]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[ikevin127]

@gijoe0295 Any plans to open a PR for this soon ? If not, please let us know so we can re-assign another Contributor and move this forward.

[gijoe0295]

PR will be opened in the next hour.