Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.27k stars 2.71k forks source link

[HOLD for payment 2024-08-01] [Workspace Feeds] [External] Create a modal for Expensify Card Enabled empty state #44306

Closed mountiny closed 3 weeks ago

mountiny commented 2 months ago

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

koko57 commented 2 months ago

Taking this issue 😊

koko57 commented 1 month ago

I will take another issue as we can put this one on hold for this PR https://github.com/Expensify/App/pull/44137 - I will use a component created there instead the ConfirmModal (more info here)

mountiny commented 1 month ago

This is off hold now

koko57 commented 1 month ago

@shawnborton I see that the component created in #44137 accepts either a lottie animation, video or an svg. How should be this asset exported?

Screenshot 2024-07-16 at 16 25 04
shawnborton commented 1 month ago

Fairly certain this one is just static, so just an .svg would do? Let me try to export something for you...

shawnborton commented 1 month ago

Let's try this and see if it works? emptystate__expensifycard.svg.zip

cc @Expensify/design - tried to make this an actual svg with no pngs embedded or anything, let's see how it goes!

koko57 commented 1 month ago

Thanks for the file! Still working on it 🙂

koko57 commented 1 month ago

@shawnborton I've just noticed that the screenshot element in the svg you exported doesn't have rounded corners

Screenshot 2024-07-18 at 10 18 06

Could you check why they're not rounded and export a new version please?🙏🏻

shawnborton commented 1 month ago

Ah good catch! Here is an updated version: emptystate__expensifycard.svg.zip

koko57 commented 1 month ago

Fighting a bit with svg size on mobile, but it's almost ready (PR in draft)

mountiny commented 1 month ago

This was merged 🎉

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.11-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-01. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 weeks ago

Issue is ready for payment but no BZ is assigned. @JmillsExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] commented 3 weeks ago

Payment Summary

[Upwork Job]()

BugZero Checklist (@JmillsExpensify)

JmillsExpensify commented 3 weeks ago

$250 for @DylanDylann for PR review and testing.

DylanDylann commented 3 weeks ago

@JmillsExpensify No need for payment here. This belongs to project

JmillsExpensify commented 3 weeks ago

Oh ok cool thanks! Closing then.