Closed mountiny closed 3 weeks ago
Taking this issue 😊
I will take another issue as we can put this one on hold for this PR https://github.com/Expensify/App/pull/44137 - I will use a component created there instead the ConfirmModal (more info here)
This is off hold now
@shawnborton I see that the component created in #44137 accepts either a lottie animation, video or an svg. How should be this asset exported?
Fairly certain this one is just static, so just an .svg would do? Let me try to export something for you...
Let's try this and see if it works? emptystate__expensifycard.svg.zip
cc @Expensify/design - tried to make this an actual svg with no pngs embedded or anything, let's see how it goes!
Thanks for the file! Still working on it 🙂
@shawnborton I've just noticed that the screenshot element in the svg you exported doesn't have rounded corners
Could you check why they're not rounded and export a new version please?🙏🏻
Ah good catch! Here is an updated version: emptystate__expensifycard.svg.zip
Fighting a bit with svg size on mobile, but it's almost ready (PR in draft)
This was merged 🎉
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.11-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-01. :confetti_ball:
For reference, here are some details about the assignees on this issue:
Issue is ready for payment but no BZ is assigned. @JmillsExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
[Upwork Job]()
$250 for @DylanDylann for PR review and testing.
@JmillsExpensify No need for payment here. This belongs to project
Oh ok cool thanks! Closing then.
Part of the Workspace feeds project.
Implement the following part of the design doc.
@koko57 @VickyStash @allgandalf @DylanDylann