Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.16k stars 2.65k forks source link

[Workspace Feeds] [External] Create UI and logic for Steps 1-6 #44309

Open mountiny opened 1 month ago

mountiny commented 1 month ago

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

koko57 commented 1 month ago

taking this one 😃

koko57 commented 4 weeks ago

update: UI for steps 2-6 is almost done. The Assignee step is a bit harder as it requires some mocking for now, I will tackle it tomorrow.

koko57 commented 3 weeks ago

Still working on the members list, I should be able to open the PR on Monday

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

DylanDylann commented 3 weeks ago

@koko57 Could you give an ETA for the PR? Thanks

koko57 commented 3 weeks ago

@DylanDylann working on it - probably today I will be able to open the PR

koko57 commented 3 weeks ago

@DylanDylann @mountiny @MariaHCD - I'm opening a draft for now, I need to fill in the checklist and test on all devices, but if you want you can take a look at the code. There are still some TODOs, but I would rather do that in another PR, ideally when the BE is ready

koko57 commented 3 weeks ago

I'm still fighting a bit with AmountForm for limit step styles and the icon not being displayed in android native, but opening this PR for the review: https://github.com/Expensify/App/pull/44741

koko57 commented 1 week ago

TODO:

koko57 commented 6 days ago

Starting to work on the integration with StartIssueNewCardFlow

koko57 commented 3 days ago

I drafted the PR for integration with the BE - @mountiny does it make sense to test it on all of the devices or web is just sufficient?

mountiny commented 3 days ago

Web and one native platform will be good for you, c+ can test all platforms

koko57 commented 3 days ago

@MariaHCD why is the employee list sent like this (pic below), not in the onyxData like in OpenWorkspaceMemberPage? Screenshot 2024-07-23 at 08 51 35Screenshot 2024-07-23 at 08 52 09

MariaHCD commented 3 days ago

why is the employee list sent like this (pic below), not in the onyxData like in OpenWorkspaceMemberPage?

The way that StartIssueNewCardFlow structures the data is a bit different from OpenWorkspaceMemberPage.

@mountiny @nkuoch Perhaps we should just have StartIssueNewCardFlow done the same way as these API endpoints?

mountiny commented 3 days ago

Yeah we need to update that to match the policy formatting

mountiny commented 3 days ago

I can try ot make a PR for this

koko57 commented 3 days ago

@mountiny could you please ping me in this issue when it'll be on staging?

mountiny commented 3 days ago

@koko57 Will do!

mountiny commented 2 days ago

Tested locally and works well, added info here