Open mountiny opened 1 month ago
taking this one 😃
update: UI for steps 2-6 is almost done. The Assignee step is a bit harder as it requires some mocking for now, I will tackle it tomorrow.
Still working on the members list, I should be able to open the PR on Monday
Triggered auto assignment to @bfitzexpensify (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
@koko57 Could you give an ETA for the PR? Thanks
@DylanDylann working on it - probably today I will be able to open the PR
@DylanDylann @mountiny @MariaHCD - I'm opening a draft for now, I need to fill in the checklist and test on all devices, but if you want you can take a look at the code. There are still some TODOs, but I would rather do that in another PR, ideally when the BE is ready
I'm still fighting a bit with AmountForm for limit step styles and the icon not being displayed in android native, but opening this PR for the review: https://github.com/Expensify/App/pull/44741
TODO:
Starting to work on the integration with StartIssueNewCardFlow
I drafted the PR for integration with the BE - @mountiny does it make sense to test it on all of the devices or web is just sufficient?
Web and one native platform will be good for you, c+ can test all platforms
@MariaHCD why is the employee list sent like this (pic below), not in the onyxData like in OpenWorkspaceMemberPage?
why is the employee list sent like this (pic below), not in the onyxData like in OpenWorkspaceMemberPage?
The way that StartIssueNewCardFlow structures the data is a bit different from OpenWorkspaceMemberPage.
@mountiny @nkuoch Perhaps we should just have StartIssueNewCardFlow done the same way as these API endpoints?
Yeah we need to update that to match the policy formatting
I can try ot make a PR for this
@mountiny could you please ping me in this issue when it'll be on staging?
@koko57 Will do!
Part of the Workspace feeds project.
Implement the following part of the design doc.
@koko57 @VickyStash @allgandalf @DylanDylann