[HOLD for payment 2024-08-01] [Workspace Feeds] [External] Create new Card Settings page - Githubissues

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.28k stars 2.71k forks source link

[HOLD for payment 2024-08-01] [Workspace Feeds] [External] Create new Card Settings page #44311

Closed mountiny closed 3 weeks ago

mountiny commented 2 months ago

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

melvin-bot[bot] commented 2 months ago

@MariaHCD, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

mountiny commented 2 months ago

Later phase of implementation

koko57 commented 1 month ago

I can start working on this issue

trjExpensify commented 1 month ago

Assigned you!

koko57 commented 1 month ago

WIP - changes are on this branch https://github.com/koko57/App/tree/feature/44311-card-settings-page. Tomorrow I'm ooo, I will continue on Monday.

allgandalf commented 1 month ago

any update on this @koko57 ?

koko57 commented 1 month ago

@allgandalf working on it, but now prioritizing last tasks from phase 1

koko57 commented 1 month ago

Last 2 days I was mainly focused on #44305 and taken over the PR for #44315. Tomorrow I'm ooo, I will get back to it next week.

koko57 commented 1 month ago

Drafted PR for now - I need to rethink one thing and probably work on a solution with Maria and I also need to test it out on all the platforms.

allgandalf commented 1 month ago

Thanks for the draft PR @koko57 , lets try to open up for review this week

koko57 commented 1 month ago

@allgandalf will be open today 😃

koko57 commented 1 month ago

@mountiny do we already have a page that "Learn more" should link to?

koko57 commented 1 month ago

@allgandalf PR opened: https://github.com/Expensify/App/pull/45415

trjExpensify commented 1 month ago

I don't think it squarely fits, but the monthly settlement requirements are on this page: https://help.expensify.com/articles/expensify-classic/expensify-card/Admin-Card-Settings-and-Features

That said:

It's an article in the Expensify Classic collection
It talks about domains etc

So I think ideally, we need to link to a New Expensify article, which is tailored to workspace feeds. @joekaufmanexpensify is leading that here (internal link): https://github.com/Expensify/Expensify/issues/408330

joekaufmanexpensify commented 1 month ago

Yep, the new help article I'm writing will include a section about the card settings page.

melvin-bot[bot] commented 1 month ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

allgandalf commented 1 month ago

The linked blocker was actually know before deploy (comment here), we are still developing the links so we can track https://github.com/Expensify/App/issues/46083 and address it once we have the links

melvin-bot[bot] commented 1 month ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.11-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/45415

If no regressions arise, payment will be issued on 2024-08-01. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@koko57 does not require payment (Contractor)
@allgandalf requires payment (Needs manual offer from BZ)

allgandalf commented 1 month ago

No payment needed here, this is part of a project

allgandalf commented 4 weeks ago

not overdue

melvin-bot[bot] commented 4 weeks ago

Issue is ready for payment but no BZ is assigned. @sonialiap you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] commented 4 weeks ago

Payment Summary

[Upwork Job]()

Contributor: @koko57 is from an agency-contributor and not due payment
ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sonialiap)

[ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[ ] I have verified the payment summary above is correct

sonialiap commented 3 weeks ago

Since no payment is needed, closing