Closed mountiny closed 3 weeks ago
@MariaHCD, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Later phase of implementation
I can start working on this issue
Assigned you!
WIP - changes are on this branch https://github.com/koko57/App/tree/feature/44311-card-settings-page. Tomorrow I'm ooo, I will continue on Monday.
any update on this @koko57 ?
@allgandalf working on it, but now prioritizing last tasks from phase 1
Last 2 days I was mainly focused on #44305 and taken over the PR for #44315. Tomorrow I'm ooo, I will get back to it next week.
Drafted PR for now - I need to rethink one thing and probably work on a solution with Maria and I also need to test it out on all the platforms.
Thanks for the draft PR @koko57 , lets try to open up for review this week
@allgandalf will be open today 😃
@mountiny do we already have a page that "Learn more" should link to?
@allgandalf PR opened: https://github.com/Expensify/App/pull/45415
I don't think it squarely fits, but the monthly settlement requirements are on this page: https://help.expensify.com/articles/expensify-classic/expensify-card/Admin-Card-Settings-and-Features
That said:
So I think ideally, we need to link to a New Expensify article, which is tailored to workspace feeds. @joekaufmanexpensify is leading that here (internal link): https://github.com/Expensify/Expensify/issues/408330
Yep, the new help article I'm writing will include a section about the card settings page.
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
The linked blocker was actually know before deploy (comment here), we are still developing the links so we can track https://github.com/Expensify/App/issues/46083 and address it once we have the links
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.11-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-01. :confetti_ball:
For reference, here are some details about the assignees on this issue:
No payment needed here, this is part of a project
not overdue
Issue is ready for payment but no BZ is assigned. @sonialiap you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
[Upwork Job]()
Since no payment is needed, closing
Part of the Workspace feeds project.
Implement the following part of the design doc.
@koko57 @VickyStash @allgandalf @DylanDylann