[HOLD for payment 2024-07-24] [Workspace Feeds] [External] Create new Reconciliation Account Settings page

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.44k stars 2.81k forks source link

[HOLD for payment 2024-07-24] [Workspace Feeds] [External] Create new Reconciliation Account Settings page #44316

Closed mountiny closed 2 months ago

mountiny commented 3 months ago

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

melvin-bot[bot] commented 3 months ago

@MariaHCD, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

mountiny commented 3 months ago

Later phase of implementation

VickyStash commented 3 months ago

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

mountiny commented 3 months ago

Thanks

VickyStash commented 3 months ago

Updates: WIP on the page functionality, I think it should be possible to open a PR tomorrow.

VickyStash commented 2 months ago

The PR has been opened for the review

allgandalf commented 2 months ago

@DylanDylann should I take this or will you?

DylanDylann commented 2 months ago

@allgandalf Feel free to rest and get better soon, I'll take care this PR

melvin-bot[bot] commented 2 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/45047

If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@VickyStash does not require payment (Contractor)
@DylanDylann requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 2 months ago

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] commented 2 months ago

Payment Summary

[Upwork Job]()

Contributor: @VickyStash is from an agency-contributor and not due payment
ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@twisterdotcom)

[ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[ ] I have verified the payment summary above is correct

DylanDylann commented 2 months ago

No need for payment here