[Workspace Feeds] [External] Integrate Deactivate_Card API

[mountiny]

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

[melvin-bot[bot]]

@MariaHCD, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

Later phase of implementation

[mountiny]

Will be worked on soon

[waterim]

Hello Im Artem from Callstack and would like to work on this issue

[trjExpensify]

Assigned you, @waterim!

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.11-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/45703

If no regressions arise, payment will be issued on 2024-08-01. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

Issue is ready for payment but no BZ is assigned. @kevinksullivan you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot[bot]]

Payment Summary

[Upwork Job]()

• Contributor: @waterim is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@kevinksullivan)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[melvin-bot[bot]]

@MariaHCD, @kevinksullivan, @mountiny, @waterim, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?

[DylanDylann]

There is no need for payment. Let's close as completed

[koko57]

maybe let's not close it as the BE is not integrated yet

[mountiny]

I think this can be worked on soon, the API commands should exist for this now

[melvin-bot[bot]]

@MariaHCD, @kevinksullivan, @mountiny, @waterim, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

We will bump this in the next update for the project

[mountiny]

We still need to integrate this with the API

[melvin-bot[bot]]

@MariaHCD, @kevinksullivan, @mountiny, @waterim, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

[koko57]

@mountiny let me know when the BE is ready for this one

[melvin-bot[bot]]

@MariaHCD, @kevinksullivan, @mountiny, @waterim, @DylanDylann Still overdue 6 days?! Let's take care of this!

[MariaHCD]

We're working on the BE: https://github.com/Expensify/Auth/pull/12150

[MariaHCD]

@koko57 The BE is ready!

As a note, the initial approach we had in the design doc is now outdated

For physical cards, we will call Card_Deactivate command with cardID, for virtual - Card_EditAdminIssuedVirtualCard with a cardLimit of 0. This will lead to the card being deactivated.

We will be using a single API command: Card_Deactivate that accepts a string authToken and int cardID for both physical cards and virtual cards.

[koko57]

@MariaHCD ok, thanks! Me or someone from our team will take care of it

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on Card_Deactivate integration.

[trjExpensify]

Assigned you, @VickyStash!

[VickyStash]

Updates: I've implemented the Card_Deactivate API call and working on the UI updates to support deactivated cards. I think the PR should be ready on Monday.

[VickyStash]

The PR is ready for the review!

[mountiny]

PR is actively being worked on