Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.27k stars 2.71k forks source link

[Workspace Feeds] [External] Create new Edit Card Limit page #44326

Closed mountiny closed 1 week ago

mountiny commented 2 months ago

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

Issue OwnerCurrent Issue Owner: @VickyStash
melvin-bot[bot] commented 2 months ago

@MariaHCD, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

mountiny commented 2 months ago

Later phase of implementation

VickyStash commented 1 month ago

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

mountiny commented 1 month ago

Thanks

VickyStash commented 1 month ago

Updates: WIP, I've implemented a new screen and route, just need to add a confirmation modal and prepare a PR. The PR should be ready on Monday (❗ tomorrow I'm OOO). Branch with updates: feature/44326-edit-card-limit

VickyStash commented 1 month ago

The PR has been opened for the review 👀

mountiny commented 1 month ago

Leaving this open to integrate the BE

melvin-bot[bot] commented 4 weeks ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 4 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.14-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-07. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 weeks ago

Issue is ready for payment but no BZ is assigned. @JmillsExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] commented 3 weeks ago

Payment Summary

[Upwork Job]()

BugZero Checklist (@JmillsExpensify)

JmillsExpensify commented 3 weeks ago

$250 summary above is correct for @DylanDylann

JmillsExpensify commented 3 weeks ago

Also remind me, are you paid via Upwork or New Expensify?

DylanDylann commented 3 weeks ago

This issue belongs to our project, There no need for payment

VickyStash commented 3 weeks ago

Since UpdateExpensifyCardLimit API endpoint is ready I'm going to work on BE integration

mountiny commented 3 weeks ago

@VickyStash thanks, hit us up in Slack if you have any questions

JmillsExpensify commented 2 weeks ago

Can I close this issue or should I keep it open?

mountiny commented 2 weeks ago

We are still connecting it to the backend so lets keep it open but you do not have to be assigned

VickyStash commented 2 weeks ago

The API call was implemented during the page implementation. There are some minor fixes/updates to make the card limit update work as expected in the PR related to OpenPolicyExpensifyCardsPage API call integration.

I've tested how UpdateExpensifyCardLimit API call works, and the result looks as expected: image

So we can just wait till the mentioned PR is merged and it should work as expected.

mountiny commented 2 weeks ago

Perfect, thanks!

mountiny commented 2 weeks ago

Not overdue, we are actively working on this one

melvin-bot[bot] commented 1 week ago

@MariaHCD, @VickyStash, @mountiny, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

mountiny commented 1 week ago

This can be closed now I think