search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.27k stars 2.71k forks source link

[Workspace Feeds] [External] Create new Edit Card Name page #44327

Open mountiny opened 2 months ago

mountiny commented 2 months ago

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

melvin-bot[bot] commented 2 months ago

@MariaHCD, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

mountiny commented 2 months ago

Later phase of implementation

mountiny commented 1 month ago

@VickyStash will work on this one

VickyStash commented 1 month ago

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash commented 1 month ago

@shawnborton Is it how the Edit Card Name page should look like? image image

shawnborton commented 1 month ago

cc @dubielzyk-expensify who worked on the UI/UX for this project. But at first glance this seems correct to me? cc @Expensify/design

VickyStash commented 1 month ago

The PR has been opened for the review

dubielzyk-expensify commented 1 month ago

Yep that looks good to me 👍

jayeshmangwani commented 1 month ago

@mountiny Melvin auto-assigned me to review the PR, but I think the Workspace feeds project's PRs will be reviewed by @allgandalf and @DylanDylann right?

allgandalf commented 1 month ago

yess @jayeshmangwani , thanks for bringing that up, we will be reviewing the PR, melvin assigned because none of us are assigned to this issue

allgandalf commented 1 month ago

I can work on that review , please assign me here @MariaHCD @mountiny

allgandalf commented 1 month ago

This was deployed to production, should we close this or any follow ups are required here @VickyStash ?

mountiny commented 1 month ago

Lets keep this open for the integration

allgandalf commented 4 weeks ago

not overdue

mountiny commented 2 weeks ago

We should be able to integrate this one this week

mountiny commented 2 weeks ago

UpdateExpensifyCardTitle

Params:

VickyStash commented 2 weeks ago

Hi! I'm going to work on BE integration of UpdateExpensifyCardTitle here

VickyStash commented 2 weeks ago

UpdateExpensifyCardTitle

Params:

  • string authToken
  • number cardID
  • string cardName

@mountiny it looks like cardTitle not cardName should be passed With cardTitle the API call works as expected. image

VickyStash commented 2 weeks ago

The PR with UpdateExpensifyCardTitle API call integration is ready for the review

trjExpensify commented 1 day ago

Any reason this issue is still open?

koko57 commented 1 day ago

it's already integrated with the BE, so we can close it