Open mountiny opened 2 months ago
@MariaHCD, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Later phase of implementation
@VickyStash will work on this one
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.
@shawnborton Is it how the Edit Card Name page should look like?
cc @dubielzyk-expensify who worked on the UI/UX for this project. But at first glance this seems correct to me? cc @Expensify/design
The PR has been opened for the review
Yep that looks good to me 👍
@mountiny Melvin auto-assigned me to review the PR, but I think the Workspace feeds project's PRs will be reviewed by @allgandalf and @DylanDylann right?
yess @jayeshmangwani , thanks for bringing that up, we will be reviewing the PR, melvin assigned because none of us are assigned to this issue
I can work on that review , please assign me here @MariaHCD @mountiny
This was deployed to production, should we close this or any follow ups are required here @VickyStash ?
Lets keep this open for the integration
not overdue
We should be able to integrate this one this week
UpdateExpensifyCardTitle
Params:
Hi! I'm going to work on BE integration of UpdateExpensifyCardTitle here
UpdateExpensifyCardTitle
Params:
- string authToken
- number cardID
- string cardName
@mountiny it looks like cardTitle
not cardName
should be passed
With cardTitle
the API call works as expected.
The PR with UpdateExpensifyCardTitle
API call integration is ready for the review
Any reason this issue is still open?
it's already integrated with the BE, so we can close it
Part of the Workspace feeds project.
Implement the following part of the design doc.
@koko57 @VickyStash @allgandalf @DylanDylann