Closed mountiny closed 3 weeks ago
@MariaHCD, @mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!
Later phase of implementation
@VickyStash will work on this one
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.
Assigned you! :)
@MariaHCD @mountiny I have a couple of questions here:
If a card limit is changed so that the remaining limit will go from >$0 to $0, we’ll throw a warning that lets the admin know this will decline transactions.
Could you confirm how the limit type change affects the remaining limit so I can calculate it right.If the card is changed to a fixed limit type and the total spend on the card exceeds the “fixed” limit (i.e. total spend over 2 months is $1,800, and admin is changing the limit type with a limit of $1,000), we won’t show Fixed as an option to switch to, because this would just terminate the card.
Where can I find the total spend value?Note: I guess the button in the screen should say 'Save' instead of the 'Next'
@VickyStash
For 1 & 2:
Could you confirm how the limit type change affects the remaining limit so I can calculate it right. Where can I find the total spend value?
I think we might need some additional thought around how to implement this. Left some initial thoughts here but I will start a fresh discussion in the channel.
Should the Smart Limit option be shown on the edit screen if the approvals are not configured in the policy?
Ah, good point. I would imagine there is no point in the SmartLimit option if approvals are not configured.
Ah, good point. I would imagine there is no point in the SmartLimit option if approvals are not configured.
@MariaHCD does it mean it's possible this screen will have only one option - Monthly
(if Fixed
and Smart
are hidden)
Yes, that's a possibility!
I think we might need some additional thought around how to implement this. Left some initial thoughts here but I will start a fresh discussion in the channel.
@MariaHCD @mountiny Maybe I can open a PR without specific checks for now, and then we can specify them when linking the page with the backend?
@VickyStash Yes, that sounds good to me. I'm aiming to start a discussion in the channel today.
Started a discussion here: https://expensify.slack.com/archives/C036QM0SLJK/p1721311425532449
Updates:
Hey @dubielzyk-expensify, I guess you were working on these mockups. Could you please confirm the buttons text
I guess it should be Save
instead of Next
.
And maybe Change limit type
instead of Change limit
.
WDYT?
cc @shawnborton
That makes sense to me. When you are just editing a single push-row and you are not in "step-by-step flow mode", we use "Save" as the button text. And your suggestion to use "Change limit type" makes sense too.
But let's definitely get a check from @dubielzyk-expensify too before moving forward.
Yep agree that those labels make more sense 👍
Thanks for raising these questions!
I agree with the latest copy changes, makes sense!
The PR has been opened for the review 👀
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.12-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-02. :confetti_ball:
For reference, here are some details about the assignees on this issue:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
@MariaHCD, @VickyStash, @mountiny Eep! 4 days overdue now. Issues have feelings too...
Not overdue, the backend has been merged
I have created a fresh issue for this one as I forgot we still had this one open. Nevertheless, I put all the details of the api command into the new issue https://github.com/Expensify/App/issues/46959 and I think its fine to close this one and handle the integration over there @waterim @VickyStash
Part of the Workspace feeds project.
Implement the following part of the design doc.
@koko57 @VickyStash @allgandalf @DylanDylann