[HOLD for payment 2024-07-10] Expense - "started settling up.." thread header shows infinite skeleton

m-natarajan commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.1-9 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Precondition:

Admin and employee are in the same workspace.
The workspace is connected to Wells Fargo bank account.
Employee does not have a bank account.

Go to staging.new.expensify.com
[Employee] Submit an expense to the workspace chat.
[Admin] Go to workspace chat with employee.
[Admin] Approve the expense.
[Admin] Pay with Expensify the expense.
[Admin] Wait for "started settling up.." message to show up, then right click on it > Reply in thread.

Expected Result:

"started settling up.." thread header will display content.

Actual Result:

"started settling up.." thread header shows infinite skeleton.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/1934b257-064b-49cf-900c-0ab47b78ed3e

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 3 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

m-natarajan commented 3 months ago

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

m-natarajan commented 3 months ago

We think that this bug might be related to #wave-collect - Release 1

aldo-expensify commented 3 months ago

I think the cause is this: https://github.com/Expensify/App/pull/40168/files#r1651736267

aldo-expensify commented 3 months ago

PR up: https://github.com/Expensify/App/pull/44357

nkdengineer commented 3 months ago

Thanks @aldo-expensify for the fix, I was not available last night.

mountiny commented 3 months ago

The CPed Pr was validated

melvin-bot[bot] commented 3 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.1-19 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/44357

If no regressions arise, payment will be issued on 2024-07-02. :confetti_ball:

melvin-bot[bot] commented 3 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@aldo-expensify] Determine if we should create a regression test for this bug.
[ ] [@aldo-expensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 3 months ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

strepanier03 commented 3 months ago

It doesn't look like we need to pay anyone for this but I believe we still need to do the checklist, at least the reg test part.

@aldo-expensify - Can you take a look at the checklist and fill out anything that is necessary? If we don't need a reg test, feel free to just close this out as done.

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.3-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/44357

If no regressions arise, payment will be issued on 2024-07-10. :confetti_ball:

melvin-bot[bot] commented 3 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@aldo-expensify] Determine if we should create a regression test for this bug.
[ ] [@aldo-expensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 2 months ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Expensify / App