Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.29k stars 2.72k forks source link

[HOLD for payment 2024-08-01] [Free trial] [$250] Not able to get rid of Expensify Chat with a GBR in the LHN #44356

Closed m-natarajan closed 1 month ago

m-natarajan commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-12 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @iwiznia Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719247632996389

Action Performed:

  1. Open the app
  2. Observe the notifications@expensify.com chat in the LHN with GBR
  3. Click on it

    Expected Result:

    GBR should be able to be removed

    Actual Result:

    Unable to make that GBR chat to disappear

ionatan@db2.sjc:~$ getreport.sh 1539158347903228 Report 1539158347903228 is Open State: 0: Open Status: 0: Open Report: created,submitted,approved,reportID,accountID,managerID,reportName,state,total,currency,status "2024-04-26 18:11:24",,,1539158347903228,0,,"Chat Report",0,0,USD,0

Submitter: accountID,email 0,fake

SharedReports: accountID,reportID,permissions 11665625,1539158347903228,"read, write" 2536717,1539158347903228,read

ReportActions: created,reportID,accountID,action,message,reportActionID "2024-04-26 18:11:24.111",1539158347903228,0,CREATED,"{""creatorAccountID"":2536717,""lastModified"":""2024-04-26 18:11:24.111""}",3522208189545905848

ReportNVPs: reportID,name,value 1539158347903228,chatType,system 1539158347903228,expensify_policyID,FAKE 1539158347903228,lastReadTime_11665625,"2024-04-26 18:11:24.111" 1539158347903228,lastReadTime_2536717,"2024-04-26 18:11:24.111" 1539158347903228,type,chat

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

image (23)

image (22)

Snip - (7) New Expensify - Google Chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013e454a42dddd3d2f
  • Upwork Job ID: 1807772836439607453
  • Last Price Increase: 2024-07-15
Issue OwnerCurrent Issue Owner: @alexpensify
melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

alexpensify commented 2 months ago

I followed up in the Slack convo to figure out if this should be internal or external.

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

alexpensify commented 2 months ago

@OfstadC - The Slack 🧵 (HERE) concluded that there should be a live troubleshooting in Slack and then mark it as External. This morning, I had to deal with one of my managed customers, and that issue took my attention. I will be OOO until Monday, July 8, and I ran out of time to host the Slack troubleshooting. I'm reassigning the issue to avoid more delays. Thanks!

melvin-bot[bot] commented 2 months ago

Job added to Upwork: https://www.upwork.com/jobs/~013e454a42dddd3d2f

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

alexpensify commented 2 months ago

@CortneyOfstad - I'm going fully OOO now and noticed that another team member was running into this issue. I've assigned external but need help to keep pushing for proposals. Thanks!

OfstadC commented 2 months ago

@alexpensify You tagged the wrong sister 😅 . I'm also largely OoO this week, but will hopefully be able to move this forward before i'm out

OfstadC commented 2 months ago

Looks like we are waiting on proposals here. I'm OoO starting tomorrow for a few days. I think this still needs a status from Wave Collect curator - so i'll bump in Slack 😃 .

@kadiealexander is buddying for me if anything increases in priority while i'm out - but i'll be popping in occasionally

OfstadC commented 2 months ago

https://expensify.slack.com/archives/C036QM0SLJK/p1719954648424619

melvin-bot[bot] commented 2 months ago

@alexpensify, @OfstadC, @suneox Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

suneox commented 2 months ago

We’re still open to proposals. I’ve posted to Slack to get more eyes

nyomanjyotisa commented 2 months ago

Any detailed steps to reproduce this issue ? I cant reproduce it. Even I cant see the Expensify Chat on the LHN on the latest main

Screenshot 2024-07-07 at 00 06 32

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

alexpensify commented 1 month ago

@OfstadC - whoops, my bad on tagging the wrong person. 🤦🏼 I'm back online and removing you from this GH. Thanks for your assistance here.


We are waiting for proposals here. @nyomanjyotisa let me review again and share the steps.

melvin-bot[bot] commented 1 month ago

@alexpensify @suneox this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

alexpensify commented 1 month ago

No update yet; waiting for proposals.

mvtglobally commented 1 month ago

Issue not reproducible during KI retests. (First week)

alexpensify commented 1 month ago

Since this isn't appearing in recent tests, I think we should close. I'll review more and confirm.

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

alexpensify commented 1 month ago

No update yet, I need to review this week.

chiragsalian commented 1 month ago

I'll take over the issue since i investigated and know how to tackle it.

mvtglobally commented 1 month ago

Issue not reproducible during KI retests. (Second week)

alexpensify commented 1 month ago

The PR is moving along through the required process.

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.11-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-01. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

alexpensify commented 1 month ago

@suneox - I sent an offer via Upwork. Please accept and I can continue the payment process tomorrow. Thanks!

https://www.upwork.com/jobs/~013e454a42dddd3d2f

suneox commented 1 month ago

@alexpensify I didn’t work on the PR and the reviewer’s checklist, so there’s no need to make a payment to me.

melvin-bot[bot] commented 1 month ago

Payment Summary

Upwork Job

BugZero Checklist (@alexpensify)

alexpensify commented 1 month ago

@suneox - thank you for your response. I'm going to close now and there is no payment summary here.