Investigate improvements of the react-compiler - Githubissues

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.1k stars 2.6k forks source link

Investigate improvements of the react-compiler #44384

Open mountiny opened 5 days ago

mountiny commented 5 days ago

We recently added react-compiler to the codebase; however, a healthcheck shows that only 937 out of 1235 files are actually compiled.

We need to understand why other ~300 components can not be compiled. At the moment we think that it could be:

because they are very complex for the compiler
break rules of the React
already optimized very well, so compiler can skip them

To figure out an exact reason we need to have verbose logging in the healthcheck. There is several PRs:

https://github.com/facebook/react/pull/29080
https://github.com/facebook/react/pull/29851 We can apply the patch package locally or wait until one of these PRs is merged and a new version is published.

kirillzyusko commented 5 days ago

I can work on this 👀