search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.43k stars 2.8k forks source link

[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-10] [$250] [Search v1] - Workspace switcher on Search is not synchronized with workspace switcher in Inbox #44433

Closed izarutskaya closed 2 months ago

izarutskaya commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.2-0 Reproducible in staging?: Y Reproducible in production?: N Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Open workspace switcher.
  3. Select any workspace other than Expensify.
  4. Go to Search.
  5. Open the workspace switcher on Search.

Expected Result:

The workspace switcher on Search should be synchronized with that on Inbox.

Actual Result:

The workspace switcher on Search shows "Expensify", but when opened, it shows the same selected workspace in Inbox.

Also, on Search page, the breadcrumbs always reset to Expensify when selecting a different Search category.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/7cc29c1c-2fce-4208-b704-a6365b764771

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01555554fcd588e68c
  • Upwork Job ID: 1805912913347680498
  • Last Price Increase: 2024-06-26
  • Automatic offers:
    • hoangzinh | Reviewer | 102886879
    • allgandalf | Contributor | 102905430
Issue OwnerCurrent Issue Owner: @anmurali
melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 3 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
izarutskaya commented 3 months ago

@anmurali I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 3 months ago

We think this issue might be related to the #vip-vsb

nyomanjyotisa commented 3 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace switcher on Search is not synchronized with workspace switcher in Inbox

What is the root cause of that problem?

We pass policyIDs to the activeWorkspaceID, and in this case policyIDs is undefined https://github.com/Expensify/App/blob/0c20881a308244867119efa6196481b65bb81274/src/pages/Search/SearchPageBottomTab.tsx#L63

What changes do you think we should make in order to solve the problem?

https://github.com/Expensify/App/blob/0c20881a308244867119efa6196481b65bb81274/src/pages/Search/SearchPageBottomTab.tsx#L62-L66 Change the code above to use activeWorkspaceID from useActiveWorkspaceFromNavigationState() if policyIDs is undefined

               <TopBar
                    activeWorkspaceID={policyIDs ?? activeWorkspaceID}
                    breadcrumbLabel={translate('common.search')}
                    shouldDisplaySearch={false}
                />

Also need to update other parts accordingly

What alternative solutions did you explore? (Optional)

Change the policyIDs with activeWorkspaceID from useActiveWorkspaceFromNavigationState()

               <TopBar
                    activeWorkspaceID={activeWorkspaceID}
                    breadcrumbLabel={translate('common.search')}
                    shouldDisplaySearch={false}
                />
melvin-bot[bot] commented 3 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01555554fcd588e68c

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

grgia commented 3 months ago

Adding External Label. Looks like the correct workspace is still selected and it's just a header display problem. I demoted from deploy blockers

bernhardoj commented 3 months ago

The policyID param isn't being passed to the search page, https://github.com/Expensify/App/blob/0c20881a308244867119efa6196481b65bb81274/src/libs/Navigation/linkTo/index.ts#L112-L115

because of the same issue as https://github.com/Expensify/App/issues/44423

WojtekBoman commented 3 months ago

Hi! I'm working on it as I'm the author of the offending PR

melvin-bot[bot] commented 3 months ago

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

luacmartins commented 3 months ago

Gonna assign myself to this one as well, since it's related to the Search project

allgandalf commented 3 months ago

I reviewed the PR https://github.com/Expensify/App/pull/44444, can i be assigned here for payment please :_)

melvin-bot[bot] commented 3 months ago

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] commented 3 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.3-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 3 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

allgandalf commented 2 months ago

I don't think a checklist is required here, this was a fix by agency member, but do let me know if we still need one

luacmartins commented 2 months ago

We can complete the items in the checklist, but we can skip the test steps, since we'll add those as part of the project wrap up.

luacmartins commented 2 months ago

Just missing payment here

allgandalf commented 2 months ago

Waiting for the Payment....

grgia commented 2 months ago

@anmurali bump on payment

melvin-bot[bot] commented 2 months ago

@anmurali, @luacmartins, @grgia, @WojtekBoman, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

anmurali commented 2 months ago

Paid.

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: