Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.12k stars 2.62k forks source link

[$250] Tags settings – Deleted tag offline reappears with empty name online #44466

Open lanitochka17 opened 1 week ago

lanitochka17 commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.2-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4671475 Email or phone of affected tester (no customers): applausetester+jpcategory_1@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Create a new workspace
  4. Navigate to the workspace editor
  5. Navigate to "More Features"
  6. Enable the tags toggle
  7. Open Tags
  8. Add a tag
  9. Go Offline and delete tag
  10. Go Online and wait a minute

Expected Result:

You haven’t created any tags banner is visible

Actual Result:

Deleted tag offline reappears with empty name online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/a1ce2a91-feb9-4aaa-822d-41383920297c

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @ikevin127
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 week ago

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 1 week ago

We think that this bug might be related to #wave-collect - Release 1

melvin-bot[bot] commented 1 week ago

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

ikevin127 commented 6 days ago

Looking for proposals.

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

Based on the comment quote above, looks like automation failed to create Upwork job and this means that the $250 bounty wasn't added to the issue title which might be part of the reason why contributors did not post proposals yet as they might be unsure of the issue status and whether it's open for proposals.

cc @abekkala

abekkala commented 6 days ago

manually created job post https://www.upwork.com/ab/applicants/1808493064874298225/job-details

melvin-bot[bot] commented 6 days ago

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

Tony-MK commented 6 days ago

@ikevin127, I tried to reproduce this issue but failed.

Are there any other missing steps?

Thanks

ikevin127 commented 5 days ago

@abekkala @Tony-MK I wasn't able to reproduce either, here are the vids:

Test method 1 Test method 2

Must've been some back-end API / pusher related issue which possibly failed to remove the tag entry from the database, while we deleted the FE onyx data -> this could explain the empty tag data.

I'd ask for a re-test and if not reproducible, close it.

melvin-bot[bot] commented 2 hours ago

@abekkala, @ikevin127 Eep! 4 days overdue now. Issues have feelings too...

ikevin127 commented 48 minutes ago

Bump on ^ https://github.com/Expensify/App/issues/44466#issuecomment-2207263518.