[$250] iOS - Distance - Center icon overlaps with compass icon

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.2-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to FAB > Submit expense > Distance
3. Use two fingers to rotate the map

Expected Result:

Center icon will not overlap with compass icon

Actual Result:

Center icon overlaps with compass icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/778a221d-284c-49cc-89fd-d17e7b2870ad

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7fdbfc969413a5e
• Upwork Job ID: 1806794874145887299
• Last Price Increase: 2024-06-28

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Distance - Center icon overlaps with compass icon

What is the root cause of that problem?

The centre icon is placed with p5 (20px) padding. https://github.com/Expensify/App/blob/67186f124eae7d7d4530c40bdba9783edd1df145/src/components/MapView/MapView.tsx#L269-L281

What changes do you think we should make in order to solve the problem?

Adjust the padding to change the position of the icon to bottom left/right.

What alternative solutions did you explore? (Optional)

Options 1. Hide the compass using compassEnabled prop.

Options 2. Updated compass position using compassPosition prop. Scale bar position can also be changed using scaleBarPosition

Option 3. Compass can also be hidden by positioning it just below the center button compassPosition={{top: 20, right: 20}}.

[trjExpensify]

Hm, @Expensify/design I'm not sure on this. Do we literally just cover the compass icon in the background or should it not be there at all?

[shawnborton]

Ah interesting, that only shows up if you rotate the map I bet?

[dannymcclain]

Ah interesting, that only shows up if you rotate the map I bet?

Yup you're right. I had never seen that compass before but I just tested out rotating the map and that's when it shows up. Womp.

[trjExpensify]

Goooot it. So both of these UI elements need to live together in the same view then conceivably?

[shawnborton]

It looks like we can also just move the compass or disable it entirely. From here:

So I like the idea of maybe moving the compass to the bottom right or something? Curious what @Expensify/design thinks.

[trjExpensify]

Got it. Bottom right, above the info button? We can pay a retainer to get rid of all the Mapbox stuff at the bottom at some point in the future.

I think we should keep the compass, as I think it's pretty standard when turning the map to reorientate it.

[shawnborton]

Yeah, that's what I was thinking. And the info button would typically always show because the default view is not to rotate the map.

[trjExpensify]

Sounds good!

[Krishna2323]

@shawnborton @trjExpensify, what do you think about placing the compass below the scale bar? I think it relates to the scale bar and should be positioned near it.

https://github.com/Expensify/App/assets/85894871/f547a51c-a7f0-4245-9c8d-ea0206acd5ba

[trjExpensify]

Works for me, but I'll defer to Shawn!

[dannymcclain]

I like it beneath the scale bar—it does feel kinda related and tucks up in there nicely. Will also wait for Shawn to weigh in 🙂

[shawnborton]

Oh I really like that too, let's do it

[Krishna2323]

@trjExpensify, can we apply the external label to get this moving?

[trjExpensify]

Let's do it!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01c7fdbfc969413a5e

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[ahmedGaber93]

@Krishna2323's alternative solutions option 2 using compassPosition to change the compass position LGTM! also, result is accepted by the design team.

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.