[Awaiting Payment Sept 16th] [Pending / Scanning] Expensify Card is not showing properly for approver on eReceipt or expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Reproducible in staging?: need reproduction (can't incur an expense on the card) Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719502162205469

Action Performed:

1. as submiterA create an expense on an Expensify Card and submit it in NewDot
2. as approverB view the submitted Expensify Card expense on NewDot

Expected Result:

Under the eReceipt cardheader should show "Expensify Card - "last 4 digits of the card"

Actual Result:

the eReceipt has the Card heading, but does not have anything under it (it should say "Expensify Card - 1234" using the last 4 digits of the card notice that the expense says Amount - Cash instead of showing as an Expensify Card expense

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012ea1806a808247bd
• Upwork Job ID: 1806706906474579791
• Last Price Increase: 2024-07-05

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[trjExpensify]

According to @grgia in this #wave-collect thread it can be fixed externally: https://expensify.slack.com/archives/C036QM0SLJK/p1719501949612399?thread_ts=1719499093.856499&cid=C036QM0SLJK

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~012ea1806a808247bd

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[trjExpensify]

I'm going to track this as part of Pending / Scanning so we keep it on the radar.

[sandipanghos]

@rojiphil in the issue description it mentioned that the receipt has a card heading but dosen't have "Expensify Card - 1234" under it. The "Expensify Card - 1234" should be below the "Expense Report #235... heading? is this the ""Expense Report #235... the e-receipt card heading?

[trjExpensify]

It should look like this:

[sandipanghos]

Thanks

[sandipanghos]

@trjExpensify how to create a expense on expense card for testing?

[trjExpensify]

Not sure, but @grgia might know how you can test this in dev.

[melvin-bot[bot]]

@rojiphil, @trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sandipanghos]

@grgia can you guide me how to test in dev. I don't have expensify card

[grgia]

I think this is actually going to end up being a BE issue. cc @rojiphil for your thoughts

The way it currently works, is we use data from the cardList in order to display a users Expensify Card. This worked great because we didn't need the expensify card data for another user before we added approver logic to New Dot. So you'd use the cardID to get the details about the card.

The approver either needs some information about member cards (only cardID, bank, and last four pin) or we need to send this information with the transaction object

[grgia]

slack post: https://expensify.slack.com/archives/C036QM0SLJK/p1720000315791989

[rojiphil]

I think this is actually going to end up being a BE issue. cc @rojiphil for your thoughts

Yeah. I too think this is a BE issue or maybe not. I think the slack conversation will decide.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[grgia]

Going to take this internal for now and update the transaction data

[melvin-bot[bot]]

@rojiphil, @trjExpensify, @grgia Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

@rojiphil @trjExpensify @grgia this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@rojiphil, @trjExpensify, @grgia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[trjExpensify]

Georgia, you've moved onto this one now right?

[grgia]

@trjExpensify yep, working on the BE fix for this today

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @rojiphil, @trjExpensify, @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

Putting this back on weekly at a minimum, though @grgia feel free to close when you're happy!

[rojiphil]

I am unassigning myself as I did not review the PR.

[trjExpensify]

Looks like @grgia's PR hit staging yesterday: https://github.com/Expensify/App/pull/46503

[melvin-bot[bot]]

@trjExpensify, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

PR is now on prod, closing.

[puneetlath]

I was just taking a look and it looks like as the approver I see the card correctly on the transaction, but not on the eReceipt.

[trjExpensify]

Georgia is out for the rest of the week. I'm wondering that's now a frontend issue @rojiphil?

[rojiphil]

Georgia is out for the rest of the week. I'm wondering that's now a frontend issue @rojiphil?

Looking into this now

[rojiphil]

PR is ready for review. @trjExpensify Can you please assign me back to the issue? Thanks.

[trjExpensify]

Sweet, thanks!

[trjExpensify]

@getusha will you be able to review that one today?

[getusha]

On it!

[Beamanator]

Approved & merged since @grgia is out this week 👍

[trjExpensify]

The PR is on staging 🎉

[puneetlath]

Nice, looks like it's working now.

[getusha]

@trjExpensify could you please assign me here? thanks!

[trjExpensify]

Done!

[trjExpensify]

Okay, so payments for this issue. It's just this PR that was reviewed and fixed externally.

• $250 to @rojiphil for the fix (will need an offer)
• $250 to @getusha for the C+ review (to request via NewDot)

Sound right? Let me know, and I'll ship offers where needed.

[rojiphil]

$250 to @rojiphil for the fix (will need an offer)

Sound right? Let me know, and I'll ship offers where needed.

Yeah. That's correct @trjExpensify. Please send an offer for the same. Thanks.

[trjExpensify]

Cool, offer sent to @rojiphil. Feel free to go and request, @getusha.

[trjExpensify]

Switching the star to me, Melv.

[rojiphil]

Cool, offer sent to @rojiphil.

@trjExpensify Accepted the offer. Thanks.

[trjExpensify]

Paid, closing!

[garrettmknight]

$250 approved for @getusha