[$250] Multi tags - Tag disappears after reordering tags and app crashes after disabling all tags

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0-3.2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace has set up with independent multi tags (A, B, C and D)
• Multi tags A and B are set to Required
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Go to + > Submit expense > Manual
  4. Proceed to confirmation page
  5. Click Show more
  6. Go to Old Dot
  7. Reorder the position from multi tag A and B to multi tag B and A, while keeping C and D untouched
  8. Note that on New Dot, multi tag A disappears from confirmation page
  9. On Old Dot, disable multi tag A and B
  10. Go to New Dot and wait for app to crash

Expected Result:

In Step 8, multi tag A will not disappear after reordering tags In Step 10, app will not crash

Actual Result:

In Step 8, multi tag A disappears after reordering tags In Step 10, app crashes after disabling all the tags

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/b14eea7d-5d75-4d30-9ae6-d35dd869a52c

Bug6527371_1719578072235!Independent.-.Multi.Level.tags.csv

logs (2).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0123c6d5064aec7c2e
• Upwork Job ID: 1806779895355813021
• Last Price Increase: 2024-07-05

Issue Owner

Current Issue Owner: @yuwenmemon

[melvin-bot[bot]]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[Christinadobrzyn]

I'm not getting the crash in testing but I am seeing the missing tag after re-organisation - I think this can be external.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0123c6d5064aec7c2e

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Filter invalid policy tags

What is the root cause of that problem?

POLICY_TAGS sync data delay & inconsistency when reorder and disable tags group and some policy tag missing tags

then we have this logic check hasEnabledTags but tags in undefined so app will crash when execute Object.values(tags)

https://github.com/Expensify/App/blob/4622e19c1da5137bc7b227f5b65bf3d83f96a909/src/libs/OptionsListUtils.ts#L1366

What changes do you think we should make in order to solve the problem?

We can filter valid tags when get policyTagLists

function getTagLists(policyTagList: OnyxEntry<PolicyTagList>): Array<ValueOf<PolicyTagList>> {
    if (isEmptyObject(policyTagList)) {
        return [];
    }

    return Object.values(policyTagList)
-       .filter((policyTagListValue) => policyTagListValue !== null)
+       .filter((policyTagListValue) => policyTagListValue !== null && !!policyTagListValue.tags)
        .sort((tagA, tagB) => tagA.orderWeight - tagB.orderWeight);
}

Or filter valid tags before execute Object.values(tags)

function hasEnabledTags(policyTagList: Array<PolicyTagList[keyof PolicyTagList]>) {
    const policyTagValueList = policyTagList.filter(policyTag => !!policyTag.tags).map(({tags}) => Object.values(tags)).flat();

What alternative solutions did you explore? (Optional)

[parasharrajat]

@suneox There are two issues in OP. One is about disappearing tags and the other is about the crash. You didn't explain the solution for the first one.

[suneox]

@suneox There are two issues in OP. One is about disappearing tags and the other is about the crash. You didn't explain the solution for the first one.

@parasharrajat About the first issue is caused by inconsistent synced data at this line

Inconsistent synced data

https://github.com/Expensify/App/assets/11959869/aaae4dcd-e6b2-4f2c-85e3-d8f76833f54e

[parasharrajat]

Can you elaborate on it? What do you mean by inconsistent sync? You are referring to the Onyx subscription.

[suneox]

Can you elaborate on it? What do you mean by inconsistent sync? You are referring to the Onyx subscription.

I mention Onyx subscription when changes in order or disabled tags in the classic app, the data on the new app is not updated correctly. I also tried to sign out and log in again, but the policy tags are still different between the classic app and the new app.

[parasharrajat]

Ok. Thanks. I believe both of these issues are backend problems. tags is a required key on the PolicyTag structure so the backend should always return a value for this key even if it is empty {}.

There are a few issues.

1. I saw that policy tags data has some lists where the tags key is [] which is supposed to be {}.
2. Secondly the the tags key should always be present, it can't be null.

:ribbon: :eyes: :ribbon: C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

@AndrewGable Could you please check this?

[suneox]

I found other places that also check for existing tags before getting the object value, so I think we should check on the client side to avoid crashes.

[parasharrajat]

That part I agree so we should probably remove those checks everywhere when backend is fixed. let's wait for @AndrewGable to look into this.

[AndrewGable]

@yuwenmemon - Do you mind stepping in here as the multi tag expert?

[yuwenmemon]

Sure thing

[Christinadobrzyn]

Just checking - do we have an update for Melvin?

[parasharrajat]

@yuwenmemon Bunmp

[yuwenmemon]

I'm OOO for the July 4th holiday so will circle back on this on Monday hopefully.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@yuwenmemon, @parasharrajat, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

Hi @yuwenmemon do you have an update on this for Melvin?

[yuwenmemon]

Not yet, but switching this to internal as per the conversation above.

[melvin-bot[bot]]

@yuwenmemon @parasharrajat @Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Christinadobrzyn]

Update for Melvin - This is going to be worked on when we have the bandwidth

[Christinadobrzyn]

I think this is still in a holding pattern

[melvin-bot[bot]]

@yuwenmemon, @parasharrajat, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

@yuwenmemon do you think you'll have the bandwidth to work on this? If not, I can reach out to the channel for another volunteer!

[melvin-bot[bot]]

@yuwenmemon, @parasharrajat, @Christinadobrzyn Still overdue 6 days?! Let's take care of this!

[Christinadobrzyn]

I think this is still in a holding pattern - waiting for a volunteer

[yuwenmemon]

Looking at this today

[yuwenmemon]

No longer seeing this crash. Additionally don't see the disappearing tag issue either. Closing:

https://github.com/user-attachments/assets/f8716caf-1fdd-475f-b231-0727b340000e

An argument could be made that the tag order should update in real-time when the tags are reordered by the admin but that's such an edge case I'm fine ignoring that for now.