Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

Improvements to Track Expense flow #44722

Closed shawnborton closed 2 weeks ago

shawnborton commented 4 months ago

We have a few improvements we'd like to make to the Track Expense flow. The main issue we'd like to address is that for Track users who are using the Search page, it is a jarring experience to send the Track user to the Inbox > SelfDM upon the creation of a tracked expense.

When a user uses global create to create a tracked expense from the search page, we want to land them back in the Search page once the expense is created. This means that we'll get rid of the post-creation whisper that happens in the selfDM and instead, add those four buttons to the Track expense confirmation page: CleanShot 2024-07-02 at 11 05 29@2x

When a user Tracks an expense from the Search page, land them back on Search after creation: image

When a user Tracks an expense from the Inbox page (or elsewhere), land them in the selfDM after creation: image

All other flows remain the same in terms of where they end (in a workspace chat, or a DM with someone else), but here's how it looks when we add those four buttons to the confirm page:

Submit it to someone: image

Categorize: image

Share with accountant: image

Note that before we open this up to external contributors, we need to:

cc @thienlnam @Expensify/design

thienlnam commented 3 months ago

This will require some significant updates in merge all the options into Track Expense. @shawnborton Is there an initiative we can tie this to? I'm unsure how to prioritize this

shawnborton commented 3 months ago

Good question. I think the thing that I want to solve for the most is the weirdness that is created for Track users who basically get pushed away from the Search page, even though the Search page is by far the optimal place for Track users who just want to sort through their own expenses.

@JmillsExpensify @trjExpensify @Expensify/design curious if you agree, and curious if you think it would make sense to address this in relation to the overall Search project?

I think we might be able to argue that a natural follow up after that would be to make it so that the tracked expenses you have on the Search page should be much easier to send to someone, like this idea:

https://github.com/user-attachments/assets/d4ba795e-8bf7-4978-bfcf-0126be9abe7a

Anyways, curious what you all think. I could see us making this part of Search, or somehow tying it into the CVP/Onboarding improvements as this is a core flow that kind of kills our viral nature at the moment.

dannymcclain commented 3 months ago

Yeah I definitely agree that adding the actions to the tracked expense makes a lot of sense. Especially because right now if you "dismiss" the whisper actions, you have no way of getting them back.

@shawnborton are you suggesting that tracked expenses always land you on the search page? Or only if you create a tracked expense while on the search page? I could honestly see an argument for either, since it's much less likely that you're going to be chatting to yourself about your own tracked expenses.

shawnborton commented 3 months ago

I can see an argument for either as well. I guess maybe the more predictable thing would be to land you where ever you started? Though I also don't mind taking an opinionated stance here and always putting the user on the Search page, since I think that would be much more expected and generally a better experience.

dannymcclain commented 3 months ago

Yeah I'm with you. I could definitely go either way, but always landing on search doesn't seem like the worst thing to me.

trjExpensify commented 3 months ago

I like this idea. The first thing that came to mind is that I'm not sure why we'd limit it to Track?

shawnborton commented 3 months ago

That's also a great point.

JmillsExpensify commented 3 months ago

Interesting one. I'll admit that I'm pretty conflicted on this one, as we already have pretty strong data supporting that Submit is our best and primary bottom-up conversion channel. That makes these improvements lower on the prioritization list for me.I do generally agree though that if you create something on the Search page you should stay there.

shawnborton commented 3 months ago

@thienlnam out of curiosity, what was the original initiative that Track expense fell under?

trjExpensify commented 3 months ago

vip-vsb.

shawnborton commented 3 months ago

Got it, so maybe we need to table this one until that ever becomes an active project again.

That being said, I do think there is something to be said about always keeping you on the Search page if you create something from the Search page. If we feel strongly, we could open up a separate ticket for that one and file it under either collect or control to move along with other Search improvements.

trjExpensify commented 3 months ago

we could open up a separate ticket for that one and file it under either collect or control to move along with other Search improvements.

I like this idea, and it would apply to both submit and track.

dannymcclain commented 3 months ago

I do think there is something to be said about always keeping you on the Search page if you create something from the Search page

Yeah I think I like this idea more than just doing it for Track.

Would the idea be that no matter what you create, we keep you in the context of where you created it (either Search or Inbox)? Basically I'm wondering if this is just an expense thing, or if it would apply to all of the global create options (track, submit, split, pay, invoice, task, travel)? Maybe that's a conversation to have on the separate issue 😅

shawnborton commented 3 months ago

Would the idea be that no matter what you create, we keep you in the context of where you created it (either Search or Inbox)? Basically I'm wondering if this is just an expense thing, or if it would apply to all of the global create options (track, submit, split, pay, invoice, task, travel)?

This would be my vote. If you started from Search, keep you on Search when you are done. We might need to get better with our navigation on the Search page before we implement something like that though. For instance, if you submit an expense to a workspace, we land you in the workspace chat. But I don't think I've seen any RHPs on the Search page show the workspace chat - it always shows the report level or transaction level. Thoughts on that @luacmartins ?

dannymcclain commented 3 months ago

I'd be in favor of that too. "Always maintain the Inbox/Search context." But like you said, it does sound like that may have significant effort involved.

luacmartins commented 3 months ago

But I don't think I've seen any RHPs on the Search page show the workspace chat - it always shows the report level or transaction level.

Correct, we only show either the expense report or the transaction thread.

I think keeping the Inbox/Search context is ideal and yea, it might be an involved solution.

JmillsExpensify commented 3 months ago

I'd be willing to add this as "search-related" polish as part of wave-control. Though I do kind of think that we add a week or monthly label and put this on the back-burner for a little bit. I want to do it eventually, it's just hard to call it a top priority with the broader feature parity initiatives in play.

shawnborton commented 3 months ago

That works for me, I can create the issue for this one and tag ya'll.

shawnborton commented 3 months ago

Issue created here: https://github.com/Expensify/App/issues/47179

shawnborton commented 2 months ago

Also cc @anmurali for visibility - we might want to just fold this all into the test we want to do where we combine the Track & Submit flows. Slack convo here for more context.

thienlnam commented 1 month ago

Currently on the back-burner

shawnborton commented 2 weeks ago

Still on the backburner. I think we are going to address some of the other issues mentioned here (being able to send a Track expense elsewhere after you create it and save it), but this one:

Always maintain the Inbox/Search context, aka if you create something from Search, stay on Search

Might be worth addressing at least?

dannymcclain commented 2 weeks ago

Always maintain the Inbox/Search context, aka if you create something from Search, stay on Search

Might be worth addressing at least?

This is already in the product!

shawnborton commented 2 weeks ago

Oh right on! I think we might just want to close this one out and start fresh with the ideas that are brewing here, curious for your thoughts on that.

dannymcclain commented 2 weeks ago

Yup I agree with that. I think our more recent ideas are better improvements for the product as a whole anyways.

shawnborton commented 2 weeks ago

Wrote a new P/S here, so I say let's just close this one out and start fresh.